Prevent negative sec and nano in TimeToROSStamp when time is large #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenN7
requested review from
nachovizzo,
benemer and
tizianoGuadagnino
as code owners
replaced Time functions with standard methods.
tizianoGuadagnino
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
I had some problems running the method on some of my bags.
Bug:
Upon testing with bags recorded recently, when reaching the TimeToROSStamp function, the returned Time object would contain negative values for sec and nanosec.
E.g. a value like
time = 1.7265783684646845e+18
was converted to:
sec = -2147483648 and nanosec = 0.
This fix computes sec and nanosec properly, in my case, i am then able to replay my bags and get the method to work.