Remove redundant Modulus operation for Voxel Hash function (#358)

* Make voxel computation consistent across all source code, also use std::floor to have explicit control over type casting

* Use available function for conversion

* Remove redundant Modulus operation for Vocel Hash function, set robin map params instead

* Make it a one liner

* remove numeric from includes

* New proposal

* remove numeric from include

* shrink diff

* Consistency as always

* Split changes into two PRs

* Revert "Merge remote-tracking branch 'origin' into gupta_fix_hash"

This reverts commit 6e46c0d, reversing
changes made to 07634eb.

---------

Co-authored-by: tizianoGuadagnino <[email protected]>
Co-authored-by: Ignacio Vizzo <[email protected]>

cpp/kiss_icp/core/VoxelHashMap.hpp

@@ -46,7 +46,7 @@ struct VoxelHashMap {
     struct VoxelHash {
         size_t operator()(const Voxel &voxel) const {
             const uint32_t *vec = reinterpret_cast<const uint32_t *>(voxel.data());
-            return ((1 << 20) - 1) & (vec[0] * 73856093 ^ vec[1] * 19349669 ^ vec[2] * 83492791);
+            return (vec[0] * 73856093 ^ vec[1] * 19349669 ^ vec[2] * 83492791);
         }
     };