Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kitti rotation error unit #224

Merged
merged 3 commits into from
Sep 21, 2023
Merged

fix kitti rotation error unit #224

merged 3 commits into from
Sep 21, 2023

Conversation

YuePanEdward
Copy link
Member

I found that the unit for average rotation error (kitti metric) might be wrong.
If deg/m is used for average rotation error's unit as here:

self.results.append(desc="Average Rotational Error", units="deg/m", value=avg_rot)

and according to here:

double avg_rot_error = 100.0 * (r_err / static_cast<double>(err.size())) / 3.14 * 180.0;

then the calculated value needs to be divided by 100.

@benemer benemer self-requested a review September 21, 2023 08:14
@benemer
Copy link
Member

benemer commented Sep 21, 2023

Good catch, thanks! Indeed, the unit of the average relative rotation error is deg/m, so it does not make sense to scale it by a factor of 100.

However, instead of fixing this in the metrics.py, I think it would make more sense to correct it in the Metrics.cpp (because it's already wrong here). Could you please change it there??

@benemer
Copy link
Member

benemer commented Sep 21, 2023

Perfect, thanks!

@benemer benemer merged commit 523fd58 into PRBonn:main Sep 21, 2023
17 checks passed
nachovizzo pushed a commit that referenced this pull request Mar 1, 2024
* fix kitti rotation error unit

* fix kitti rotation error unit

* fix kitti rotation error unit

---------

Co-authored-by: yuepan <Yue Pan>
Co-authored-by: Yue Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants