Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paint map in global view #269

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Paint map in global view #269

merged 2 commits into from
Jan 29, 2024

Conversation

benemer
Copy link
Member

@benemer benemer commented Jan 24, 2024

Solves #268

When using global view, we now paint the map in gray (which can be seen with a black and white background). Even though the default coordinate-based rendering looks better for local map inspection, it will paint the local map black in the global view. In the local view (which should be used to inspect the map) we keep the original rendering.

image

I am also open to other color suggestions or ways to rescale the default colormap :)

@benemer benemer requested a review from nachovizzo January 24, 2024 10:45
@benemer benemer self-assigned this Jan 24, 2024
Copy link
Collaborator

@nachovizzo nachovizzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tizianoGuadagnino tizianoGuadagnino merged commit 656bcae into main Jan 29, 2024
17 checks passed
@tizianoGuadagnino tizianoGuadagnino deleted the benedikt/fix_map_color branch January 29, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants