Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove always True flag #281

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

nachovizzo
Copy link
Collaborator

This also makes the C++ and Python pipelines closer, since C++ has no option to enable/disable preprocessing

I have no strong opinions, so we can decide whether to keep this config. I haven't realized that we never use it, as "preprocessing" is just cropping the min/max range of the cloud, so I'd say it is something we always want to do....

Let me know what you guys think

This also makes the C++ and Python pipelines closer, since the C++ has
no option to enable/disable preprocessing
Copy link
Member

@benemer benemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no need for that. It is anyway confusing to have min_range and max_range in the config and then not always using it.

Can be merged in my view!

Copy link
Collaborator

@tizianoGuadagnino tizianoGuadagnino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it <3

@tizianoGuadagnino tizianoGuadagnino merged commit 44d8563 into main Feb 29, 2024
17 checks passed
@tizianoGuadagnino tizianoGuadagnino deleted the nacho/remove_unused_config branch February 29, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants