Fix Ubuntu 20.04 dev build #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachovizzo
changed the title
Closed
tizianoGuadagnino
approved these changes
Jul 9, 2024
tizianoGuadagnino
approved these changes
Jul 9, 2024
benemer
approved these changes
Jul 10, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #334, which was introduced at #252
Fix dev machine broken build
So I managed to reproduce the problem reported in #334 in one shot here
FYI: Ubuntu 22.04 is not a problem due to a higher TBB version; proof here:
Fix
Changing the way we query the default max concurrency fixes the dev build
Why?
Our glory build system will use the TBB version available and only install from the source if it is not there. Otherwise, the system won't build.
It looks like the default shipped version doesn't have
NUMA_SUPPORT, and thus, this symbol is not created at compile time, for whatever reason.