Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix include headers #365

Merged
merged 12 commits into from
Jul 12, 2024
Merged

Fix include headers #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a61c11e
Make voxel computation consistent across all source code, also use st…
saurabh1002 Jul 2, 2024
adf8f4d
Use available function for conversion
saurabh1002 Jul 2, 2024
1fbaf9a
Merge pull request #1 from PRBonn/main
saurabh1002 Jul 4, 2024
fd3a27e
Make it a one liner
tizianoGuadagnino Jul 8, 2024
13a9e11
remove numeric from includes
tizianoGuadagnino Jul 8, 2024
d7a56c0
New proposal
nachovizzo Jul 9, 2024
ecb5ba2
remove numeric from include
nachovizzo Jul 9, 2024
11314be
shrink diff
nachovizzo Jul 9, 2024
66ef872
Consistency as always
nachovizzo Jul 9, 2024
16e20e2
Merge pull request #2 from PRBonn/main
saurabh1002 Jul 10, 2024
8952ca0
Fix include header, follow IWYU
saurabh1002 Jul 11, 2024
43b7509
Merge branch 'PRBonn:main' into main
saurabh1002 Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/kiss_icp/core/Preprocessing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
#include <tsl/robin_map.h>

#include <Eigen/Core>
#include <Eigen/Geometry>
#include <algorithm>
#include <cmath>
#include <sophus/se3.hpp>
#include <vector>

namespace {
Expand Down
2 changes: 0 additions & 2 deletions cpp/kiss_icp/core/Preprocessing.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
#pragma once

#include <Eigen/Core>
#include <sophus/se3.hpp>
#include <utility>
#include <vector>

namespace kiss_icp {
Expand Down
3 changes: 2 additions & 1 deletion cpp/kiss_icp/core/Threshold.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@
// SOFTWARE.
#include "Threshold.hpp"

#include <Eigen/Core>
#include <Eigen/Geometry>
#include <cmath>
#include <sophus/se3.hpp>

namespace kiss_icp {
AdaptiveThreshold::AdaptiveThreshold(double initial_threshold,
Expand Down
3 changes: 1 addition & 2 deletions cpp/kiss_icp/core/VoxelHashMap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@

#include <Eigen/Core>
#include <algorithm>
#include <tuple>
#include <utility>
#include <sophus/se3.hpp>
#include <vector>

namespace kiss_icp {
Expand Down
1 change: 1 addition & 0 deletions cpp/kiss_icp/metrics/Metrics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "Metrics.hpp"

#include <Eigen/Core>
#include <Eigen/Geometry>
#include <algorithm>
#include <cassert>
#include <cmath>
Expand Down
Loading