Use relative names for topics #415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdila
requested review from
nachovizzo,
benemer and
tizianoGuadagnino
as code owners
|
Looks good to me! Can you please check the CI? I think formatting is failing |
|
Weird, I just modified the code from the github editor for the PR (I'm lazy and I have a private fork with lots of edits to suit my needs), seems like one line was already broken. Anyway fixed in the last commit. |
|
No, I think the Now it looks good! Thanks for the fix. |
benemer
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick PR to address issue #414
Tested locally, if you run kiss_icp without a namespace everything stays as before this PR, if a namespace is specified messages are published on namespace/kiss/
Also updated the .rviz config to match this modifications and also allow to run rviz with a namespace.