Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish map in odom_lidar frame #417

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benemer
Copy link
Member

@benemer benemer commented Dec 18, 2024

When publishing the point clouds for visualization, for each LiDAR frame, we unnecessarily transform the local map points to the sensor frame to publish it with the same frame as the LiDAR frame. This PR avoids the transformation by directly publishing the local map points in their frame_id.

We already discussed this in #285. After #371, in which we added the odom_lidar to the tf tree, we can now easily publish the local map at this frame_id (assuming that publish_odom_tf is set to true). If publish_odom_tf is false, we will now see both the estimated trajectory and the local map because both are published in odom_lidar, which is the default fixed frame in rviz.

This is also how we currently do it in Kinematic-ICP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant