Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the effect group across 1 directory with 4 updates #683

Merged
merged 4 commits into from
Feb 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
265 changes: 137 additions & 128 deletions package-lock.json

Large diffs are not rendered by default.

7 changes: 3 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,11 @@
"type": "module",
"dependencies": {
"@arendjr/text-clipper": "npm:@jsr/arendjr__text-clipper@^3.0.0",
"@effect/platform": "0.58.20",
"@effect/platform-node": "^0.53.19",
"@effect/schema": "^0.68.17",
"@effect/platform": "0.75.1",
"@effect/platform-node": "^0.71.1",
"@js-temporal/polyfill": "^0.4.4",
"bullmq": "^5.34.8",
"effect": "3.4.7",
"effect": "3.12.7",
"html-entities": "^2.5.2",
"http-status-codes": "^2.3.0",
"ioredis": "^5.4.1",
Expand Down
4 changes: 2 additions & 2 deletions src/CoarNotify.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Schema } from '@effect/schema'
import { Schema } from 'effect'
import * as Doi from './Doi.js'
import * as Url from './Url.js'

Expand Down Expand Up @@ -28,6 +28,6 @@ export const RequestReviewSchema = Schema.Struct({
actor: Schema.Struct({
id: Url.UrlFromStringSchema,
type: Schema.Literal('Application', 'Group', 'Organization', 'Person', 'Service'),
name: Schema.String.pipe(Schema.trimmed(), Schema.nonEmpty()),
name: Schema.NonEmptyTrimmedString,
}),
})
5 changes: 2 additions & 3 deletions src/Crossref.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { HttpClient, type HttpClientError, HttpClientRequest, HttpClientResponse } from '@effect/platform'
import { type ParseResult, Schema } from '@effect/schema'
import { Context, Data, Effect, Equal, Layer, Match, Tuple } from 'effect'
import { Context, Data, Effect, Equal, Layer, Match, type ParseResult, Schema, Tuple } from 'effect'
import { StatusCodes } from 'http-status-codes'
import * as Doi from './Doi.js'
import * as Temporal from './Temporal.js'
Expand Down Expand Up @@ -31,7 +30,7 @@ export const CrossrefApiLive = Layer.effect(
Effect.gen(function* (_) {
const response = yield* _(
HttpClientRequest.get(`works/${encodeURIComponent(doi)}`),
okClient,
okClient.execute,
Effect.flatMap(HttpClientResponse.schemaBodyJson(MessageSchema(WorkSchema))),
)

Expand Down
3 changes: 1 addition & 2 deletions src/CrossrefPreprint.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Schema } from '@effect/schema'
import { Array, Data, Effect, Either, Match, String, pipe } from 'effect'
import { Array, Data, Effect, Either, Match, Schema, String, pipe } from 'effect'
import * as Crossref from './Crossref.js'
import * as Doi from './Doi.js'
import * as Temporal from './Temporal.js'
Expand Down
5 changes: 2 additions & 3 deletions src/Datacite.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { HttpClient, type HttpClientError, HttpClientRequest, HttpClientResponse } from '@effect/platform'
import { type ParseResult, Schema } from '@effect/schema'
import { Context, Data, Effect, Equal, Layer, Match } from 'effect'
import { Context, Data, Effect, Equal, Layer, Match, type ParseResult, Schema } from 'effect'
import { StatusCodes } from 'http-status-codes'
import * as Doi from './Doi.js'
import * as Temporal from './Temporal.js'
Expand Down Expand Up @@ -31,7 +30,7 @@ export const DataciteApiLive = Layer.effect(
Effect.gen(function* (_) {
const response = yield* _(
HttpClientRequest.get(`dois/${encodeURIComponent(doi)}`),
okClient,
okClient.execute,
Effect.flatMap(HttpClientResponse.schemaBodyJson(DataSchema('dois', WorkSchema))),
)

Expand Down
3 changes: 1 addition & 2 deletions src/DatacitePreprint.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Schema } from '@effect/schema'
import { Array, Data, Effect, Either, Match, Predicate, String, pipe } from 'effect'
import { Array, Data, Effect, Either, Match, Predicate, Schema, String, pipe } from 'effect'
import * as Datacite from './Datacite.js'
import * as Doi from './Doi.js'
import * as Temporal from './Temporal.js'
Expand Down
3 changes: 1 addition & 2 deletions src/Doi.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { ParseResult, Schema } from '@effect/schema'
import { Brand, Either, Option, type Predicate, String, flow } from 'effect'
import { Brand, Either, Option, ParseResult, type Predicate, Schema, String, flow } from 'effect'

export type Doi = Brand.Branded<string, 'Doi'>

Expand Down
3 changes: 1 addition & 2 deletions src/LanguageCode.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Schema } from '@effect/schema'
import type { Predicate } from 'effect'
import { type Predicate, Schema } from 'effect'
import iso6391, { type LanguageCode } from 'iso-639-1'

export { type LanguageCode } from 'iso-639-1'
Expand Down
43 changes: 27 additions & 16 deletions src/Logger.ts
Original file line number Diff line number Diff line change
@@ -1,29 +1,40 @@
import { Headers, HttpClient, UrlParams } from '@effect/platform'
import { Effect } from 'effect'
import { Effect, flow } from 'effect'

export const LoggingHttpClient = HttpClient.makeDefault(request =>
Effect.Do.pipe(
Effect.tap(() =>
export const LoggingHttpClient = Effect.andThen(
HttpClient.HttpClient,
flow(
HttpClient.tapRequest(request =>
Effect.logDebug('Sending HTTP Request').pipe(
Effect.annotateLogs({ headers: Headers.redact(request.headers, 'authorization') }),
Effect.annotateLogs({
headers: Headers.redact(request.headers, 'authorization'),
url: request.url,
urlParams: UrlParams.toString(request.urlParams),
method: request.method,
}),
),
),
Effect.zipRight(HttpClient.fetch(request)),
Effect.tap(response =>
HttpClient.tap(response =>
Effect.logDebug('Received HTTP response').pipe(
Effect.annotateLogs({ status: response.status, headers: response.headers }),
Effect.annotateLogs({
status: response.status,
headers: response.headers,
url: response.request.url,
urlParams: UrlParams.toString(response.request.urlParams),
method: response.request.method,
}),
),
),
Effect.tapErrorTag('RequestError', error =>
HttpClient.tapError(error =>
Effect.logError('Error sending HTTP request').pipe(
Effect.annotateLogs({ reason: error.reason, error: error.error }),
Effect.annotateLogs({
reason: error.reason,
error: error.cause,
url: error.request.url,
urlParams: UrlParams.toString(error.request.urlParams),
method: error.request.method,
}),
),
),
Effect.annotateLogs({
url: request.url,
urlParams: UrlParams.toString(request.urlParams),
method: request.method,
}),
Effect.withLogSpan('fetch'),
),
)
4 changes: 2 additions & 2 deletions src/OpenAi.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import 'openai/shims/web'
import { HttpClient } from '@effect/platform'
import { FetchHttpClient } from '@effect/platform'
import { Config, Context, Data, Effect, Layer, Option, Redacted, identity } from 'effect'
import * as OAI from 'openai'

Expand All @@ -16,7 +16,7 @@ interface OpenAiService {

const make = (params: { readonly apiKey: Redacted.Redacted }) =>
Effect.gen(function* (_) {
const fetchService = yield* _(Effect.serviceOption(HttpClient.Fetch))
const fetchService = yield* _(Effect.serviceOption(FetchHttpClient.Fetch))
const fetch = Option.match(fetchService, { onNone: () => globalThis.fetch, onSome: identity })

const client = new OAI.OpenAI({
Expand Down
9 changes: 4 additions & 5 deletions src/OpenAlex/OpenAlexApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ import {
HttpClientResponse,
type UrlParams,
} from '@effect/platform'
import { ParseResult, Schema } from '@effect/schema'
import { Brand, Context, Data, Effect, Either, Equal, Layer, RateLimiter, pipe } from 'effect'
import { Brand, Context, Data, Effect, Either, Equal, Layer, ParseResult, RateLimiter, Schema, pipe } from 'effect'
import { StatusCodes } from 'http-status-codes'
import * as Doi from '../Doi.js'
import * as LanguageCode from '../LanguageCode.js'
Expand Down Expand Up @@ -56,7 +55,7 @@ export const OpenAlexApiLive = Layer.scoped(
pipe(
HttpClientRequest.get(`https://api.openalex.org/works/${encodeURIComponent(Doi.toUrl(id).href)}`),
HttpClientRequest.acceptJson,
HttpClient.filterStatus(httpClient, status => Equal.equals(status, StatusCodes.OK)),
HttpClient.filterStatus(httpClient, status => Equal.equals(status, StatusCodes.OK)).execute,
Effect.flatMap(HttpClientResponse.schemaBodyJson(WorkSchema)),
Effect.scoped,
Effect.catchAll(GetWorkError.fromError),
Expand All @@ -68,7 +67,7 @@ export const OpenAlexApiLive = Layer.scoped(
HttpClientRequest.get('https://api.openalex.org/works'),
HttpClientRequest.setUrlParams(params),
HttpClientRequest.acceptJson,
HttpClient.filterStatus(httpClient, status => Equal.equals(status, StatusCodes.OK)),
HttpClient.filterStatus(httpClient, status => Equal.equals(status, StatusCodes.OK)).execute,
Effect.flatMap(HttpClientResponse.schemaBodyJson(ListOfWorksSchema)),
Effect.scoped,
Effect.catchAll(ListWorksError.fromError),
Expand Down Expand Up @@ -153,7 +152,7 @@ export const WorkSchema = Schema.Struct({
doi: Doi.DoiFromUrlSchema,
language: LanguageCode.LanguageCodeSchema,
primary_location: Schema.Struct({
source: Schema.optional(Schema.Struct({ id: Schema.compose(Url.UrlFromStringSchema, SourceIdFromUrlSchema) }), {
source: Schema.optionalWith(Schema.Struct({ id: Schema.compose(Url.UrlFromStringSchema, SourceIdFromUrlSchema) }), {
nullable: true,
}),
}),
Expand Down
3 changes: 1 addition & 2 deletions src/Preprint.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Schema } from '@effect/schema'
import { Data, Effect, Match, flow } from 'effect'
import { Data, Effect, Match, Schema, flow } from 'effect'
import type * as Crossref from './Crossref.js'
import * as CrossrefPreprint from './CrossrefPreprint.js'
import type * as Datacite from './Datacite.js'
Expand Down
4 changes: 2 additions & 2 deletions src/Prereview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ export function writeAPrereviewUrl(doi: Doi.Doi) {
)
}

export const preprintIsReady = (doi: Doi.Doi): Effect.Effect<boolean, never, HttpClient.HttpClient.Default> =>
export const preprintIsReady = (doi: Doi.Doi): Effect.Effect<boolean, never, HttpClient.HttpClient> =>
Effect.gen(function* (_) {
const httpClient = yield* _(HttpClient.HttpClient)

const request = HttpClientRequest.head(writeAPrereviewUrl(doi))

const response = yield* _(httpClient(request))
const response = yield* _(httpClient.execute(request))

return Equal.equals(response.status, StatusCodes.OK)
}).pipe(
Expand Down
7 changes: 3 additions & 4 deletions src/ReviewRequest.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import clip from '@arendjr/text-clipper'
import { Schema } from '@effect/schema'
import { Array, Context, Data, Effect, Exit, Match, String, pipe } from 'effect'
import { Array, Context, Data, Effect, Exit, Match, Schema, String, pipe } from 'effect'
import { decode } from 'html-entities'
import mjml from 'mjml'
import slackifyMarkdown from 'slackify-markdown'
Expand Down Expand Up @@ -29,8 +28,8 @@ const ThreadSchema = Schema.Struct({
posts: Schema.NonEmptyArray(
Schema.Struct({
text: Schema.String,
fields: Schema.optional(Schema.Array(Schema.String), { default: Array.empty }),
actions: Schema.optional(Schema.Array(Schema.Literal('write-prereview')), { default: Array.empty }),
fields: Schema.optionalWith(Schema.Array(Schema.String), { default: Array.empty }),
actions: Schema.optionalWith(Schema.Array(Schema.Literal('write-prereview')), { default: Array.empty }),
}),
),
})
Expand Down
7 changes: 3 additions & 4 deletions src/Router.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { HttpMiddleware, HttpRouter, HttpServerRequest, HttpServerResponse } from '@effect/platform'
import { Schema, TreeFormatter } from '@effect/schema'
import { Array, Config, Context, Data, Effect, Exit, Match, Option } from 'effect'
import { Array, Config, Context, Data, Effect, Exit, Match, Option, ParseResult, Schema } from 'effect'
import { StatusCodes } from 'http-status-codes'
import { createHash } from 'node:crypto'
import slackifyMarkdown from 'slackify-markdown'
Expand All @@ -27,7 +26,7 @@ class RedisTimeout extends Data.TaggedError('RedisTimeout') {
const NewPrereviewSchema = Schema.Struct({
url: Url.UrlFromStringSchema,
author: Schema.Struct({
name: Schema.String.pipe(Schema.trimmed(), Schema.nonEmpty()),
name: Schema.NonEmptyTrimmedString,
}),
})

Expand Down Expand Up @@ -196,7 +195,7 @@ export const Router = HttpRouter.empty.pipe(
Effect.gen(function* (_) {
yield* _(
Effect.logInfo('Invalid request').pipe(
Effect.annotateLogs({ message: TreeFormatter.formatErrorSync(error) }),
Effect.annotateLogs({ message: ParseResult.TreeFormatter.formatErrorSync(error) }),
),
)

Expand Down
25 changes: 12 additions & 13 deletions src/Slack.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { HttpClient, type HttpClientError, HttpClientRequest, HttpClientResponse } from '@effect/platform'
import { Schema } from '@effect/schema'
import { Brand, Context, Data, Effect } from 'effect'
import { Brand, Context, Data, Effect, Schema } from 'effect'
import * as Url from './Url.js'

export interface SlackApiConfig {
Expand All @@ -23,12 +22,12 @@ const TimestampSchema = Schema.fromBrand(SlackTimestamp)(Schema.String)

const PlainTextObjectSchema = Schema.Struct({
type: Schema.Literal('plain_text'),
text: Schema.String.pipe(Schema.nonEmpty()),
text: Schema.NonEmptyString,
})

const MrkdwnTextObjectSchema = Schema.Struct({
type: Schema.Literal('mrkdwn'),
text: Schema.String.pipe(Schema.nonEmpty()),
text: Schema.NonEmptyString,
})

const TextObjectSchema = Schema.Union(PlainTextObjectSchema, MrkdwnTextObjectSchema)
Expand Down Expand Up @@ -109,19 +108,19 @@ export const chatPostMessage = (
): Effect.Effect<
{ readonly channel: SlackChannelId; readonly timestamp: SlackTimestamp },
SlackError,
HttpClient.HttpClient.Default | SlackApiConfig
HttpClient.HttpClient | SlackApiConfig
> =>
Effect.gen(function* (_) {
const client = yield* _(slackClient)

const request = yield* _(
HttpClientRequest.post('chat.postMessage', { headers: {} }),
HttpClientRequest.setHeader('Content-Type', 'application/json'),
HttpClientRequest.schemaBody(ChatPostMessageSchema)(message),
HttpClientRequest.schemaBodyJson(ChatPostMessageSchema)(message),
)

const response = yield* _(
client(request),
client.execute(request),
Effect.flatMap(HttpClientResponse.schemaBodyJson(ChatPostMessageResponseSchema)),
Effect.scoped,
)
Expand All @@ -142,18 +141,18 @@ export const chatPostMessage = (

export const chatDelete = (
message: Schema.Schema.Type<typeof ChatDeleteSchema>,
): Effect.Effect<void, SlackError, HttpClient.HttpClient.Default | SlackApiConfig> =>
): Effect.Effect<void, SlackError, HttpClient.HttpClient | SlackApiConfig> =>
Effect.gen(function* (_) {
const client = yield* _(slackClient)

const request = yield* _(
HttpClientRequest.post('chat.delete'),
HttpClientRequest.setHeader('Content-Type', 'application/json'),
HttpClientRequest.schemaBody(ChatDeleteSchema)(message),
HttpClientRequest.schemaBodyJson(ChatDeleteSchema)(message),
)

const response = yield* _(
client(request),
client.execute(request),
Effect.flatMap(HttpClientResponse.schemaBodyJson(ChatDeleteResponseSchema)),
Effect.scoped,
)
Expand All @@ -174,7 +173,7 @@ export const chatDelete = (

export const chatGetPermalink = (
message: Schema.Schema.Type<typeof ChatGetPermalinkSchema>,
): Effect.Effect<URL, SlackError, HttpClient.HttpClient.Default | SlackApiConfig> =>
): Effect.Effect<URL, SlackError, HttpClient.HttpClient | SlackApiConfig> =>
Effect.gen(function* (_) {
const client = yield* _(slackClient)

Expand All @@ -183,7 +182,7 @@ export const chatGetPermalink = (
const request = HttpClientRequest.get('chat.getPermalink', { urlParams })

const response = yield* _(
client(request),
client.execute(request),
Effect.flatMap(HttpClientResponse.schemaBodyJson(ChatGetPermalinkResponseSchema)),
Effect.scoped,
)
Expand Down Expand Up @@ -217,5 +216,5 @@ const toSlackError = (error: unknown): SlackError => {
}

const httpToSlackError = (error: HttpClientError.HttpClientError): SlackError => {
return new SlackError({ cause: error.error instanceof Error ? error.error : undefined, message: error.reason })
return new SlackError({ cause: error.cause instanceof Error ? error.cause : undefined, message: error.reason })
}
3 changes: 1 addition & 2 deletions src/Temporal.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { ParseResult, Schema } from '@effect/schema'
import { Temporal } from '@js-temporal/polyfill'
import { Clock, Effect, Tuple } from 'effect'
import { Clock, Effect, ParseResult, Schema, Tuple } from 'effect'

export const { Instant, PlainDate, PlainYearMonth } = Temporal

Expand Down
2 changes: 1 addition & 1 deletion src/Url.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ParseResult, Schema } from '@effect/schema'
import { ParseResult, Schema } from 'effect'

export const UrlFromSelfSchema: Schema.Schema<URL> = Schema.instanceOf(URL)

Expand Down
Loading