[33]- Added env variables #119
Conversation
WalkthroughThe changes involve updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant API
User->>API: Request OTP for Health ID
API-->>User: Send OTP
User->>API: Verify OTP
API-->>User: Confirm Verification
User->>API: Generate Health ID
API-->>User: Provide Health ID
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
| @@ -50,6 +50,7 @@ export const environment = { | |||
| visualAcuityTest: `Visual Acuity Test`, | |||
| haemoglobinTest: `Haemoglobin Test`, | |||
| parentAPI: `${MMU_API}`, | |||
| abhaExtension: `@abdm`, | |||
There was a problem hiding this comment.
This can be a variable.
In non production environments the value will be for sandbox - @sbx
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (2)
src/environments/environment.ci.ts (2)
427-427: Maintain consistent capitalization in comments.In the comment on line 427, consider changing 'Urls' to 'URLs' to match standard capitalization.
Apply this diff to fix the comment:
- /** Previous Anthropometry Urls */ + /** Previous Anthropometry URLs */
431-451: Ensure consistent casing of 'OTP' in variable names.There is inconsistency in the casing of 'OTP' in variable names. For clarity and consistency, consider standardizing the usage of 'OTP'. It's common to use uppercase for acronyms in camelCase variable names.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- src/environments/environment.ci.ts (2 hunks)
- src/environments/environment.ci.ts.template (3 hunks)
Additional comments not posted (14)
src/environments/environment.ci.ts (5)
53-53: VariableabhaExtensionadded successfully.The addition aligns with existing configuration patterns.
438-438: Fix inconsistent casing in the variable namegethealthIdDetailsUrl.The variable
gethealthIdDetailsUrlhas inconsistent casing; consider renaming it togetHealthIdDetailsUrlto follow camelCase conventions.Apply this diff to rename the variable:
-gethealthIdDetailsUrl: `${FHIR_API}healthID/getBenhealthID`, +getHealthIdDetailsUrl: `${FHIR_API}healthID/getBenhealthID`,Likely invalid or redundant comment.
465-465: Fix inconsistent casing in the variable namegetdeviceRDServiceUrl.The variable
getdeviceRDServiceUrlshould be renamed togetDeviceRDServiceUrlto follow camelCase conventions.Apply this diff to rename the variable:
-getdeviceRDServiceUrl: `${COMMON_API}biometric/getBiometricData/`, +getDeviceRDServiceUrl: `${COMMON_API}biometric/getBiometricData/`,Likely invalid or redundant comment.
456-456: Fix inconsistent casing in the variable namerelationShipUrl.The variable
relationShipUrlhas inconsistent casing; consider renaming it torelationshipUrlto follow camelCase conventions.Apply this diff to rename the variable:
-relationShipUrl: `${TM_API}registrar/registrarMasterData`, +relationshipUrl: `${TM_API}registrar/registrarMasterData`,Likely invalid or redundant comment.
466-466: Correct the spelling of 'Aadhar' to 'Aadhaar' in the variable name.The correct spelling is 'Aadhaar'; consider renaming
confirmAadharBiotoconfirmAadhaarBiofor accuracy and consistency.Apply this diff to fix the spelling:
-confirmAadharBio: `${FHIR_API}healthIDWithBio/confirmWithAadhaarBio`, +confirmAadhaarBio: `${FHIR_API}healthIDWithBio/confirmWithAadhaarBio`,Likely invalid or redundant comment.
src/environments/environment.ci.ts.template (9)
38-38: Addition ofFHIR_APIconstant aligns with existing conventionsThe
FHIR_APIconstant is added to store the base URL for FHIR API endpoints, following the established pattern for API constants.
55-55: Addition ofabhaExtensionproperty is consistentThe
abhaExtensionproperty is introduced with the value@abdm. This addition aligns with the existing configuration properties within the environment settings.
430-430: Addition ofgetAllRegistrationDataendpointThe
getAllRegistrationDataendpoint is added at${COMMON_API}customization/fetchAllData. Ensure that this endpoint is correctly implemented on the server side and that it handles data securely, especially if it returns sensitive registration data.
435-444: New Health ID OTP Generation URLs are properly definedThe following Health ID OTP generation and verification URLs have been added:
otpGenerationUrlotpGenerationWithUIDUrlhealthIdGenerationUrlhealthIdGenerationWithUIDUrlverifyOTPUrlcheckAndGenerateMobileOTPUrlverifyMobileOTPUrlgethealthIdDetailsUrlmapHealthIdUrlThese URLs are correctly constructed using the
FHIR_APIbase URL and follow the existing naming conventions.
446-447: Care Context Mapping URLs added correctlyThe care context mapping endpoints have been added:
careContextGenerateOtpUrlverifyOtpForMappingContextUrlThese additions are consistent with the established patterns in the configuration.
450-451: Health ID Validation URLs are properly addedThe following Health ID validation URLs have been included:
generateOTPForHealthIDValidationverifyOTPForHealthIDValidationThey are appropriately defined and use the correct base URL.
454-455: Health ID Card Generation URLs added successfullyThe URLs for Health ID Card generation are:
generateOTPForHealthIDCardverifyOTPAndGenerateHealthCardThese URLs are correctly formed and fit within the existing configuration structure.
457-457:updateAmritIDInMongoendpoint addedThe
updateAmritIDInMongoendpoint is added to the configuration. Verify that proper error handling and data validation are implemented when this endpoint is used, to maintain data integrity in the MongoDB database.
460-466: Family Tagging URLs are correctly integratedThe following family tagging URLs have been added:
relationShipUrlsaveFamilyTaggingUrleditFamilyTaggingUrluntagFamilyUrlfamilySearchUrlcreateFamilyUrlgetFamilyMemberUrlThese endpoints are appropriately defined and consistent with the rest of the configuration.
| getdeviceRDServiceUrl: `${COMMON_API}biometric/getBiometricData/`, | ||
| confirmAadharBio: `${FHIR_API}healthIDWithBio/confirmWithAadhaarBio`, | ||
|
|
||
| generateABHAForBio: `${FHIR_API}healthIDWithBio/verifyBio`, | ||
| generateABHAForBioMobileOTP: `${FHIR_API}healthIDWithBio/generateMobileOTP`, |
There was a problem hiding this comment.
Ensure secure handling of Biometric Health ID endpoints
The addition of biometric-related endpoints includes:
getdeviceRDServiceUrlconfirmAadharBiogenerateABHAForBiogenerateABHAForBioMobileOTP
Given the sensitivity of biometric data, please ensure that all necessary security measures are in place, such as encryption and secure communication protocols. Compliance with data protection regulations (e.g., GDPR, HIPAA) should be verified.
📋 Description
JIRA ID:
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit
These enhancements improve the overall functionality of health ID management within the application.