Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulation/gz_bridge: Add support for lidar altitude sensors #23755

Closed
wants to merge 2 commits into from

Conversation

Myzhe
Copy link

@Myzhe Myzhe commented Oct 1, 2024

Solved Problem

While reading the docs I realized that there is currently no support for distance sensors (rangefinders) for GZ. The feature already exists for gazebo-classic so I thought it would be a nice addition for GZ as well.

Altitude sensors would allow for fixed-wing mission landings without tweaking the parameters (to ignore the missing terrains sensor).

The feature should also be a part of #23602.

Solution

  • Add distance_sensor publisher to gz_bridge based on (1D) gz LaserScan messages
  • Rename laserScanCallback() to lidarObstacleScanCallback() as there are now two gz LaserScan subscriptions
  • Add lidar distance sensor to rc_cessna and advanced_plane models (Add lidar altimeter sensors PX4-gazebo-models#58)

Changelog Entry

For release notes:

Feature GZ supports lidar altitude sensors

Alternatives

I don't see any alternatives besides just not implementing the feature.

Test coverage

@Myzhe Myzhe force-pushed the gz-lidar-altitude-sensor branch from 8a8d5c3 to 8c37e45 Compare October 1, 2024 15:39
@dakejahl
Copy link
Contributor

dakejahl commented Oct 1, 2024

There's a branch here that adds support for range finder already, maybe take a look
#23456
and the PR for the x500 model with range finder
PX4/PX4-gazebo-models#51

@hamishwillee
Copy link
Contributor

No comment on the actual PR but when/if lidar or optical flow simulations go in, would be good to document - specifically in the gazebo docs to explain what you can use the models for (including things like the default range settings) and to use it. Also linked from rangefinder section and sections like those on terrain following so that people can work out how they might test the behaviour from there too. FYI @dakejahl :-)

@Myzhe
Copy link
Author

Myzhe commented Oct 2, 2024

There's a branch here that adds support for range finder already, maybe take a look #23456 and the PR for the x500 model with range finder PX4/PX4-gazebo-models#51

Oh that is neat! I will close the PR as (almost) everything is already covered in your draft.

But would suggest that there should exist a fixed wing model (rc_cessna, advanced_plane, or a new one) that has a rangefinder installed. It is strongly recommended for a fixed-wing mission landing. I think it would be nice if you could include that in your gz-models PR :)

@Myzhe Myzhe closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants