Add FusedEmbeddingSeqPoolGradKernel op for merge #19452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test=develop
test=develop
…ool_with_sparse_matrix' into emb_seq_grad merge fused_emb_seq op fw
test=develop
test=develop
test=develop
test=develop
|
@yihuaxu please help to review this PR |
jianhang-liu
suggested changes
Sep 2, 2019
test=develop
zhaify
force-pushed
the
emb_seq_grad
branch
7 times, most recently
from
d0d6cf3 to
0b3ea16
Compare
test=develop
|
close due to #19770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
d_table->Resize(table_dim);in line 204