[SOT] Avoid breakgraph when setitem and iterate paddle defined layerlist #71039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because github say `Unknown owner on line 72: make sure @DrRyanHuang exists and has write access to the repository`
|
你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- tools/check_file_diff_approvals.sh: Language not supported
SigureMo
changed the title
SigureMo
changed the title
gouzil
approved these changes
Feb 8, 2025
SigureMo
deleted the
sot/avoid-breakgraph-when-setitem-and-iterate-user-defined-layerlist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Performance
Description
消除最近模型上发现的一些新打断问题，包括
RangeVariableand setitem and add compilation count stats #70851 引入flatten_inner_vars挂掉，[SOT][3.13] split certainLOAD_ATTRin 3.13+ & replaceget_itemsandflatten_itemswithflatten_inner_vars,while replacing special cases with inheritance & remove method_name attribute in MethodVariable #70927 引入RNNBase），则应该直接 call layer，否则可能会因为这部分手写代码而发生打断以及一些优化
将有点问题，可能和 [Dy2St]Fix recurrent op eager deletion pass error in dy2st #47105 相关，后面看看paddle.nn.RNN从not_supported_paddle_layer移除，这只是曾经因为 PIR 不支持控制流的临时策略PCard-66972