[NPU] add pointer conversion to aclTensor #1476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
YanhuiDua
reviewed
Nov 22, 2024
| // Ptr ConvertType to aclTensor | ||
| static const auto aclCreateTensor = GET_OP_API_FUNC(aclCreateTensor); | ||
| if (aclCreateTensor == nullptr) { | ||
| return nullptr; |
There was a problem hiding this comment.
返回nullptr的可以抛个warning，感觉会好些
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目前aclnn接口调用EXEC_NPU_CMD中，ConvertTpye只支持DenseTensor等参数向aclTensor的转换，而不支持指针数据转换。
现增加phi::float16和int8_t向aclTensor的转换