Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #463. Expose LLDP neighbors on EthernetInterface #464

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DavidVentura
Copy link

Description

This change adds a new function: get_lldp_neighbors to EthernetInterface, which returns a list of LLDP neighbors from the device.

Motivation and Context

LLDP is very useful to determine whether patching was carried out correctly, see #463

How Has This Been Tested?

I am testing this on a PA-850.

Lint rules from the contributing guidelines were broken prior to this change

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

I have not added tests, I couldn't find a test for get_counters to base my test on, is there a similar test I can use as an example?

@welcome-to-palo-alto-networks
Copy link

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btorresgil

Does this feel like it should be in an opstate namespace...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants