added new_appid to allowed parameters for ApplicationFilter. Need to … #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
formatting needs to be addressed |
|
@shinmog Hey! I managed to get formatting to pass. I have an extension 'auto pep8' which was causing the silly issue. Should be clear now :) Might have another PR this evening for another issue. |
shinmog
approved these changes
Feb 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
## [1.12.0](v1.11.0...v1.12.0) (2024-04-11) ### Features * **ApplicationFilter:** Add new_appid parameter ([#547](#547)) ([bc96108](bc96108)) * **Firewall:** New fields for show_system_resources ([#544](#544)) ([9e8cc2a](9e8cc2a)) * Handling Log Collector Group (LCG) pushes ([#493](#493)) ([7e87952](7e87952)) * **panos/network:** Advanced routing engine ([#539](#539)) ([173bb8a](173bb8a)) * Enhance updater logic ([#548](#548)) ([23ed1ad](23ed1ad)) * **network.BgpPolicyRule:** Add action_community_modifier param ([#535](#535)) ([58ce888](58ce888)), closes [#534](#534) * **PanDevice:** add `is_ready()` ([#532](#532)) ([a6b018e](a6b018e)) ### Bug Fixes * **_parse_job_results:** Catch None details in response ([#471](#471)) ([f01ae25](f01ae25)), closes [#470](#470)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
## [1.12.0](v1.11.0...v1.12.0) (2024-04-11) ### Features * **ApplicationFilter:** Add new_appid parameter ([#547](#547)) ([bc96108](bc96108)) * **Firewall:** New fields for show_system_resources ([#544](#544)) ([9e8cc2a](9e8cc2a)) * Handling Log Collector Group (LCG) pushes ([#493](#493)) ([7e87952](7e87952)) * **panos/network:** Advanced routing engine ([#539](#539)) ([173bb8a](173bb8a)) * Enhance updater logic ([#548](#548)) ([23ed1ad](23ed1ad)) * **network.BgpPolicyRule:** Add action_community_modifier param ([#535](#535)) ([58ce888](58ce888)), closes [#534](#534) * **PanDevice:** add `is_ready()` ([#532](#532)) ([a6b018e](a6b018e)) ### Bug Fixes * **_parse_job_results:** Catch None details in response ([#471](#471)) ([f01ae25](f01ae25)), closes [#470](#470)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 11, 2024
## [1.12.0](v1.11.0...v1.12.0) (2024-04-11) ### Features * **ApplicationFilter:** Add new_appid parameter ([#547](#547)) ([bc96108](bc96108)) * **Firewall:** New fields for show_system_resources ([#544](#544)) ([9e8cc2a](9e8cc2a)) * Handling Log Collector Group (LCG) pushes ([#493](#493)) ([7e87952](7e87952)) * **panos/network:** Advanced routing engine ([#539](#539)) ([173bb8a](173bb8a)) * Enhance updater logic ([#548](#548)) ([23ed1ad](23ed1ad)) * **network.BgpPolicyRule:** Add action_community_modifier param ([#535](#535)) ([58ce888](58ce888)), closes [#534](#534) * **PanDevice:** add `is_ready()` ([#532](#532)) ([a6b018e](a6b018e)) ### Bug Fixes * **_parse_job_results:** Catch None details in response ([#471](#471)) ([f01ae25](f01ae25)), closes [#470](#470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pep8 formattin
Added additional parameter for applicationfilter class to allow for "Apply to New App-IDs only"
Motivation and Context
#522
#518
How Has This Been Tested?
Tested against Panorama lab environment, verified filter created and had the correct "Apply to New App-IDs only" check box checked.
Screenshots (if appropriate)
N/A
Types of changes
Checklist