fix(panos/base): Added check for commit_response
text validation
#557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With latest develop/master branch commit (not yet released) - there was an issue committing to Panorama which has no changes to commit (discovered when running the
panos_commit_panorama
ansible module).Motivation and Context
Simple python script to test the issue:
from panos.panorama import Panorama, PanoramaCommitAll, PanoramaCommit
Result:
How Has This Been Tested?
Tested with above mentioned script. After validation was added:
Ansible task also passes:
Test with an actual commit is still working properly:
Screenshots (if appropriate)
Types of changes
Checklist