Added an optional frameswritten setter #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 96.35% 96.29% -0.07%
==========================================
Files 12 12
Lines 1180 1187 +7
==========================================
+ Hits 1137 1143 +6
- Misses 43 44 +1 ☔ View full report in Codecov by Sentry. |
coretl
reviewed
Dec 14, 2023
evalott100
force-pushed
the
add_ringbuffer
branch
from
e3ad641 to
715bd5f
Compare
coretl
reviewed
Dec 18, 2023
evalott100
force-pushed
the
add_ringbuffer
branch
2 times, most recently
from
418ab45 to
70feb3f
Compare
evalott100
force-pushed
the
add_ringbuffer
branch
3 times, most recently
from
1465540 to
8fbe219
Compare
|
@coretl completely forgot about adding the test till now. dmgav approved the ioc side add_ringbuffer PR so after this is released I'll merge and release that if CI is all good? |
coretl
reviewed
Jan 24, 2024
Added a new thread that sets the NumCaptured PV Added a new EndReason
Added a test to verify that the number of frames written is passed downstream in the pipeline
evalott100
force-pushed
the
add_ringbuffer
branch
from
28ee7da to
14dcc00
Compare
coretl
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional setter in the HDF5 writer to set a record detailing the number of frames written.
We require merging and release of this PR before the ioc side: PandABlocks/PandABlocks-ioc#83
According to DiamondLightSource/pythonSoftIOC#142, the set of a record should be thread safe, but we should do some testing before we release.