net5.0-windows #59
net5.0-windows #59
Conversation
|
I used Simple-MAPI.NET netstandard2.0 version from this PR Simple-MAPI.NET netstandard2.0 target framework |
|
Thanks yeah, I should pull in the netstandard2 PR from SimpleMAPI first and then come back to this one |
| return ApplicationDeployment.IsNetworkDeployed ? | ||
| ApplicationDeployment.CurrentDeployment.CurrentVersion.ToString() : _info.AppAssembly.GetName().Version.ToString(); | ||
| return _info.AppAssembly.GetName().Version.ToString(); | ||
| // lost during migration to net5.0 |
There was a problem hiding this comment.
That's a bugger isn't it...
On my current team, this ClickOnce deployed version is quite important - we might have to use conditional code/preprocessing or something to keep this...
src/Tests/AssemblyDigger_Tests.cs
Outdated
| @@ -13,7 +13,9 @@ public void Can_Dig_Assembly_Refs_By_Name() | |||
| var digger = new AssemblyDigger(Assembly.Load("ExceptionReporter.NET")); | |||
| var refs = digger.GetAssemblyRefs().ToList(); | |||
|
|
|||
| Assert.That(refs.Select(r => r.Name), Is.SupersetOf(new [] {"System.Core", "DotNetZip", "SimpleMapi.NET"})); | |||
| //TODO: is "System.Core" necessesary here? | |||
| //Assert.That(refs.Select(r => r.Name), Is.SupersetOf(new [] {"System.Core", "DotNetZip", "SimpleMapi.NET"}));// | |||
There was a problem hiding this comment.
Yeah no, System.Core isn't necessary here.
This is just a slightly dodgy "integration" test I did... testing for DLLs I knew should be there, at the time. We can just remove that check
|
I noticed a lot of people are missing the One user's solution is this I noticed he replaces If we could write something like that, conditional on NET50, maybe... |
|
Actually, reading this MS blog, I get the idea that the most practical option here is to target .netstandard 2.0 - to basically support both .NetFramework and .NET5 https://devblogs.microsoft.com/dotnet/the-future-of-net-standard/
|
There is a dependency on WinForms therefore it can't be targeted on .netstandart 2.0 |
This PR will update the ExceptionReporter.NET to support the
net5.0-windowsTargetFrameworkI have tested it manually and all seems OK.
Also, I have run UnitTests for
net5.0-windowsand 2 of them were red:Can_Dig_Assembly_Refs_By_Name()- I assume it was false negative. This test checked the existence of "System.Core" but it wasn't necessary(?)Can_Render_Text_Template_Baseline_1_Of_Everything()- the problem is in Handlebars 2.0.2. There are newer versions of Handlebars, but them had more bugs (more failed unit tests). Later I will report about it to the maintainers of Handlebars