-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChunkGenerator - add getHeight to ChunkData #12311
Conversation
- remove unused imports - fix spacing issue
A check for out of bound position might be nice like the other methods and then return 0 (or throw) to avoid unexpected value. And the first line of javadocs seems incomplete. |
Thats a good idea, thank you, good catch.
Well that is embarrassing 😬 edit: updated! thanks again. |
- not sure what I did here, but I missed a good chunk of this
I'd just throw if it's OOB and make the checks clearer with <0 / >15 |
Sounds good to me, thank you. |
This PR aims to add an option to ChunkGenerator.ChunkData to get the current height.
This allows to get the height generated in a previous step.
For example, let's say I have a generator where I allow Minecraft to generate the noise, but I want to generate the surface.
I can get the height that was previously generated in the noise step, and plop my surface block on top of that in the surface step.
Closes #12048