RideCommand - config to remove player as vehicle restriction

[ShaneBeee]

This PR aims to remove the player as vehicle restriction in the vanilla /ride command.
Its well know that the API allows mounting any entity to the player as a passenger, so it seems fitting to allow this in the ride command as well.
Unfortunately Mojang imposed a restriction here.
Some people may often rely on this command for funsies, or possibly even for debugging/testing when writing code.

Doc PR: PaperMC/docs#552

[Owen1212055]

Not really a fan of changing vanilla behavior of commands like this.

[NonSwag]

Plugins can't really hook into this to allow riding players, so some way to allow it anyway would be nice
MAYBE a config option?
But yes, as Owen said, completely removing this check is meh

[ShaneBeee]

well dang.

[kennytv]

Owen is cringe that's fine, but yeah a config option would be good

[ShaneBeee]

ok cool, I'll attempt a config option, and report back when I get that figured out.

[ShaneBeee]

Ok, that was a heck of a lot easier than I expected.
Id love some feedback on my very wordy config option.
Too wordy? Just right? Not wordy enough?

[NonSwag]

what about skipPlayerRideRestrictionCheck?
Still very long but opposed to rideCommandSkipPlayerAsVehicleRestriction

[ShaneBeee]

what about skipPlayerRideRestrictionCheck? Still very long but opposed to rideCommandSkipPlayerAsVehicleRestriction

I worry that that does not explain which command tho.

I could do rideCommandSkipPlayerRestriction

[NonSwag]

i mean, you have the comment... sooo...

[ShaneBeee]

i mean, you have the comment... sooo...

true, but that doesn't show in the actual config, ie:

[NonSwag]

yaml is weird
i think your name is alright
the average key length in that file makes it appear shorter

[ShaneBeee]

yaml is weird i think your name is alright the average key length in that file makes it appear shorter

thank you "suggest-player-names-when-null-tab-completions" for making me look fine 😆

[lynxplay]

rideCommandAllowPlayerAsVehicle seems shorter and does the same.
Additionally, please open a pr at papermc/docs for this feaature 👍

[ShaneBeee]

rideCommandAllowPlayerAsVehicle seems shorter and does the same. Additionally, please open a pr at papermc/docs for this feaature 👍

Done and done:
PaperMC/docs#552
:)