Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add client-side RemoveMultipleOrgUsersMutation #10805

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: add client-side RemoveMultipleOrgUsersMutation #10805

wants to merge 6 commits into from

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Feb 6, 2025 •
edited
Loading

Description

Following up #10675, this PR is the client-side mutation

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

parabol-release-bot bot and others added 3 commits February 6, 2025 15:46
@parabol-release-bot @tianrunhe
chore(release): release v8.23.8 (#10792)
e3d7b6e 
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
@tianrunhe
Wire up related subscriptions
752d3f6
@tianrunhe
Remove demo UI element for RemoveMultipleOrgUsersMutation
3d5b1a2
@github-actions github-actions bot added the size/m label Feb 6, 2025
@tianrunhe tianrunhe marked this pull request as ready for review February 6, 2025 14:06
@tianrunhe tianrunhe requested a review from Dschoordsch February 6, 2025 14:06
Dschoordsch
Dschoordsch requested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test

packages/server/graphql/public/mutations/removeMultipleOrgUsers.ts Outdated Show resolved Hide resolved
packages/server/graphql/public/mutations/removeMultipleOrgUsers.ts Outdated Show resolved Hide resolved
packages/client/mutations/RemoveMultipleOrgUsersMutation.ts
const taskIds = tasks.map((task) => task.getValue('id'))
handleRemoveTasks(taskIds, store)
} else {
handleUpsertTasks(tasks, store)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 did not test, but don't we need to do this for all tasks with userId !== viewerId?

packages/server/graphql/public/mutations/removeMultipleOrgUsers.ts Outdated Show resolved Hide resolved
packages/server/graphql/public/mutations/removeMultipleOrgUsers.ts Outdated Show resolved Hide resolved
packages/server/graphql/public/mutations/removeMultipleOrgUsers.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dschoordsch Dschoordsch Dschoordsch requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianrunhe @Dschoordsch