fix lint errors

Signed-off-by: Matt Krick <matt.krick@gmail.com>

packages/embedder/JobQueueStream.ts

@@ -12,7 +12,7 @@ import numberVectorToString from './indexing/numberVectorToString'
 import {updateJobState} from './indexing/updateJobState'
 
 type Job = Selectable<DB['EmbeddingsJobQueue']>
-export default class JobQueueStream implements AsyncIterator<Job> {
+export default class JobQueueStream implements AsyncIterableIterator<Job> {
   private dataLoader: RootDataLoader
   private modelManager: ModelManager
 

packages/embedder/ai_models/OpenAIGeneration.ts

@@ -6,8 +6,6 @@ import {
   GenerationOptions
 } from './AbstractGenerationModel'
 
-const MAX_REQUEST_TIME_S = 3 * 60
-
 export type ModelId = 'gpt-3.5-turbo-0125' | 'gpt-4-turbo-preview'
 
 type OpenAIGenerationOptions = Omit<GenerationOptions, 'topK'>
@@ -27,7 +25,7 @@ function isValidModelId(object: any): object is ModelId {
 
 export class OpenAIGeneration extends AbstractGenerationModel {
   private openAIApi: OpenAI | null
-  private modelId: ModelId
+  private modelId!: ModelId
 
   constructor(config: GenerationModelConfig) {
     super(config)

packages/embedder/ai_models/RecursiveCharacterTextSplitter.ts

@@ -50,7 +50,7 @@ which is longer than the specified ${this.chunkSize}`
           // - we have a larger chunk than in the chunk overlap
           // - or if we still have any chunks and the length is long
           while (total > this.chunkOverlap || (total + _len > this.chunkSize && total > 0)) {
-            total -= currentDoc[0].length
+            total -= currentDoc[0]!.length
             currentDoc.shift()
           }
         }
@@ -70,10 +70,10 @@ which is longer than the specified ${this.chunkSize}`
     const separators = this.separators
 
     // Get appropriate separator to use
-    let separator: string = separators[separators.length - 1]
+    let separator: string = separators[separators.length - 1]!
     let newSeparators: string[] | undefined
     for (let i = 0; i < separators.length; i += 1) {
-      const s = separators[i]
+      const s = separators[i]!
       if (s === '') {
         separator = s
         break

packages/embedder/ai_models/TextEmbeddingsInference.ts

@@ -50,7 +50,7 @@ export class TextEmbeddingsInference extends AbstractEmbeddingsModel {
         return new Error(`listOfTokens list length !== 1 (length: ${listOfTokens.length})`)
       return listOfTokens[0]
     } catch (e) {
-      return e instanceof Error ? e : new Error(e)
+      return e instanceof Error ? e : new Error(typeof e === 'string' ? e : 'Unknown error')
     }
   }
   public async getEmbedding(content: string) {
@@ -73,7 +73,7 @@ export class TextEmbeddingsInference extends AbstractEmbeddingsModel {
       return listOfVectors[0]
     } catch (e) {
       console.log(`TextEmbeddingsInference.getEmbeddings() timeout: `, e)
-      return e instanceof Error ? e : new Error(e || 'Unknown Error')
+      return e instanceof Error ? e : new Error(typeof e === 'string' ? e : 'Unknown error')
     }
   }
 

packages/embedder/mergeAsyncIterators.ts

@@ -12,8 +12,8 @@ type UnIt<T extends AsyncIterator<any>> = UnYield<Awaited<ReturnType<T['next']>>
 // Promise.race has a memory leak
 // To avoid: https://github.com/tc39/proposal-async-iterator-helpers/issues/15#issuecomment-1937011820
 export function mergeAsyncIterators<
-  T1 extends AsyncIterator<any>,
-  T2 extends AsyncIterator<any>,
+  T1 extends AsyncIterableIterator<any>,
+  T2 extends AsyncIterableIterator<any>,
   K1 = UnIt<T1>,
   K2 = UnIt<T2>
 >(iterables: [T1, T2]) {

packages/gql-executor/RedisStream.ts

@@ -3,7 +3,7 @@ import RedisInstance from 'parabol-server/utils/RedisInstance'
 type MessageValue = [prop: string, stringifiedData: string]
 type Message = [messageId: string, value: MessageValue]
 type XReadGroupRes = [streamName: string, messages: Message[]]
-export default class RedisStream implements AsyncIterator<string> {
+export default class RedisStream implements AsyncIterableIterator<string> {
   private stream: string
   private consumerGroup: string
   // xreadgroup blocks until a response is received, so this needs its own connection