Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organized Component Library #18

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

mmb186
Copy link

@mmb186 mmb186 commented Nov 15, 2017

No description provided.

@EdHurtig
Copy link
Member

Friendly DevOps Note: Upon Merge Pls Select "Squash & Merge" for this Pull Request.
screen shot 2017-11-15 at 8 45 40 pm

Copy link
Collaborator

@jmassucco17 jmassucco17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Organization is welcome. Please address the following:
-The .pretty files should only have .kicad_mod files inside. No sub-folders and no libs. See https://github.com/KiCad/kicad-footprints for reference
-We did not understand libs when we made all those libraries each with a single symbol. Libraries can contain many symbols - you should consolidate related components into libraries, either grouped by manufacturer or function (see https://github.com/KiCad/kicad-library/tree/master/library for reference)

@lukemerkl lukemerkl self-requested a review November 16, 2017 02:00
Copy link
Member

@lukemerkl lukemerkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much everything James said. We discussed the incorrect use of the .lib files the other day. Maybe you or Colin missed a commit?

Copy link
Member

@lukemerkl lukemerkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the same as the screenshot from earlier, which was correct. :(

Controllers, Texas Instruments, etc should not be folders containing .lib files. They should be .lib files with multiple components called out in the text. so, if you were to create Texas Instruments.lib it would contain the definitions for the lm321_5pin, the lmR16030s, the lmx93, and so on. Right now you are designating the LM321_5pin, for example, as a Library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants