Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organized Paradigm Library (Correctly this time, hopefully) #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mmb186
Copy link

@mmb186 mmb186 commented Nov 16, 2017

Restructured ParadigmLibrary components into their respective .lib files and renamed module folders with .pretty to follow the KiCad/kicad-footprints structure

…les and renamed module folders with .pretty to follow the KiCad/kicad-footprints structre
Copy link
Member

@lukemerkl lukemerkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change connectors,pretty to connectors.pretty and you should be good! the .lib files look correct

@jmassucco17 jmassucco17 self-requested a review November 16, 2017 22:49
Copy link
Collaborator

@jmassucco17 jmassucco17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor fixes:
-Capacitor.pretty -> Capacitors.pretty
-Connectors,pretty -> Deleted
-Optocoupler.pretty -> Optocouplers.pretty (generally, pluralize all component names)
-Resistors,pretty -> Resistors.pretty (and deleted sub-folder "SMD")
-Remove .DS_Store files (can put these in .gitignore)
-Diods.lib -> Diodes.lib
Also, please check with Ed about the way you're doing this merge. It looks like you forked our repo, made changes, and are now attempting to merge back in. Normally, you should just create a branch within our repo for changes like this.

@jmassucco17 jmassucco17 requested a review from EdHurtig November 16, 2017 22:55
@EdHurtig
Copy link
Member

Going to withhold my review until James and Merkl feel their changes are complete because repeating the same 90% of aforementioned stuff is unhelpful and makes it hard to identify the 10% of stuff that hasn't already been said

…lers.pretty, Resistors,pretty -> Resistors.pretty, Diods.lib -> Diodes.lib and removed *.DS_Store files
@EdHurtig
Copy link
Member

@jmassucco17 this PR is done on a branch making it much easier to review and checkout. The "squash and merge" button can be found on this PR below and should be used when this is finally ready to compress all the changes into a single commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants