feature/PI/raspbian-dockerfile-taskrunner #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colton-smith
changed the title
colton-smith
changed the title
Burke-Daniel
reviewed
Mar 3, 2020
Pidaq/README.md
Outdated
|
|
||
| Includes relevant examples | ||
| *** | ||
| Ensure docker is installed and running on your machine. Windows 10 Home does not have proper support for docker, however MUN offers a free upgrade to windows 10 education which is fully featured. The update is easy, unintrusive, and tasks less than 1 hour. |
There was a problem hiding this comment.
Lil typo here, "tasks" should be "takes"
Burke-Daniel
reviewed
Mar 3, 2020
Pidaq/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| !important vscode/tasks.json | |||
There was a problem hiding this comment.
Should this be .vscode/tasks.json? I think that directory is still getting gitignored, just noticed this when following the instructions on the README
There was a problem hiding this comment.
You're correct, fixed
Burke-Daniel
approved these changes
Mar 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature branch reuses a Dockerfile and some parts of the readme created by Mark Duffet for CompV at: ParadigmHyperloop/comp5-software#7
Features: