-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces The SM Crush Bonus With a New Mechanic: Gas Coefficient #27168
Open
Migratingcocofruit
wants to merge
15
commits into
ParadiseSS13:master
Choose a base branch
from
Migratingcocofruit:CrushBonusChange
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Replaces The SM Crush Bonus With a New Mechanic: Gas Coefficient #27168
Migratingcocofruit
wants to merge
15
commits into
ParadiseSS13:master
from
Migratingcocofruit:CrushBonusChange
+69
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrabang
requested changes
Oct 22, 2024
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
label
Oct 22, 2024
Drafting this until anomalies are figured out |
Henri215
added
Balance
This PR will modify how effective something is or isnt
Tweak
This PR tweaks something ingame
labels
Oct 23, 2024
ParadiseSS13-Bot
added
-Status: Awaiting approval
This PR is waiting for approval internally
-Status: Awaiting review
This PR is awaiting review from the review team
and removed
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
-Status: Awaiting approval
This PR is waiting for approval internally
labels
Oct 28, 2024
The issues here have been resolved for a while, but due to the PTL revert it puts me over the limit so I'm closing it for now. |
Singulo Buffs got merged so I'm back under the limit. |
PTL is merged for real now, so I am once again reopening this PR |
Migratingcocofruit
changed the title
SM crush bonus change
Replaces The SM Crush Bonus With a New Mechanic: Gas Coefficient
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-Status: Awaiting review
This PR is awaiting review from the review team
Balance
This PR will modify how effective something is or isnt
Merge Conflict
This PR is merge conflicted
TGUI
This PR modifies TGUI, will conflict
Tweak
This PR tweaks something ingame
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Replaces the SM crush bonus with Gas Coefficient(GC). which is dependent on the moles of each gas in the chamber. Gas Coefficient starts at 1, and alters the engine's radiation output by multiplying it with EER, meaning the effective EER for rad production is EER * GC.
The modifiers for each gas are:
So if we had 11333 moles of CO2 in the chamber, and the EER was 7000 our total radiation output would be equivalent to:
GC * EER = 2 * 7000 = 14000 EER
The Gas Coefficient is increased by any amount of any of those gasses, in proportion to their amount. This means that generally more gas leads to a higher GC, but you will still get some boost even when the overall mole count is below the original crush threshold.
Adds per tile total and per gas mole count as well as the current mix's gas coefficient to the supermatter monitoring console.
Anomalies now happen when EER * Gas Coefficient is above 5000.
Why It's Good For The Game
Crush is an uninteresting mechanic, just a flat boost to power when a certain amount of gas is in the chamber. It does carry some risk in cases where the engine delams, but usually crush setups mitigate that to begin with just due to how difficult it is for them to be set on fire. In addition, the N2 crush setup offered too much reward for too little risk, being the equivalent of a 7000EER engine without the arcs and gas generation.
Changing to bonus that is dependent on EER and gives greater bonuses for more dangerous gasses should reward risk better as well as give more room to experiment with interesting gas mixes to try and optimize the different parts of the equation.
Images of changes
Testing
Declaration
Changelog
🆑
tweak: Changed the SM crush bonus to depend on EER, the amount of each gas in the chamber.
tweak: Adds the mole count and gas coefficient of the gas mix in the chamber as well as the mole count of each gas to the supermatter monitoring console
/:cl: