Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces The SM Crush Bonus With a New Mechanic: Gas Coefficient #27168

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

Migratingcocofruit
Copy link
Contributor

@Migratingcocofruit Migratingcocofruit commented Oct 22, 2024

What Does This PR Do

Replaces the SM crush bonus with Gas Coefficient(GC). which is dependent on the moles of each gas in the chamber. Gas Coefficient starts at 1, and alters the engine's radiation output by multiplying it with EER, meaning the effective EER for rad production is EER * GC.
The modifiers for each gas are:

  • O2: +1.15 to Gas Coefficient at 11333 Moles per tile
  • CO2: +1 to Gas Coefficient at 11333 Moles per tile
  • N2/N2O: +0.55 to Gas Coefficient at 11333 Moles per tile
  • Plasma: +4 to Gas Coefficient at 11333 Moles per tile

So if we had 11333 moles of CO2 in the chamber, and the EER was 7000 our total radiation output would be equivalent to:
GC * EER = 2 * 7000 = 14000 EER

The Gas Coefficient is increased by any amount of any of those gasses, in proportion to their amount. This means that generally more gas leads to a higher GC, but you will still get some boost even when the overall mole count is below the original crush threshold.

Adds per tile total and per gas mole count as well as the current mix's gas coefficient to the supermatter monitoring console.

Anomalies now happen when EER * Gas Coefficient is above 5000.

Why It's Good For The Game

Crush is an uninteresting mechanic, just a flat boost to power when a certain amount of gas is in the chamber. It does carry some risk in cases where the engine delams, but usually crush setups mitigate that to begin with just due to how difficult it is for them to be set on fire. In addition, the N2 crush setup offered too much reward for too little risk, being the equivalent of a 7000EER engine without the arcs and gas generation.
Changing to bonus that is dependent on EER and gives greater bonuses for more dangerous gasses should reward risk better as well as give more room to experiment with interesting gas mixes to try and optimize the different parts of the equation.

Images of changes

image

Testing

  • Messed around with different gas mixes and observed the expected power boost in the debugger.
  • Observed anomaly generation occur according to EER and the crush bonus.
  • Made sure all values in the console are correct and are displayed correctly

Declaration

image

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Changed the SM crush bonus to depend on EER, the amount of each gas in the chamber.
tweak: Adds the mole count and gas coefficient of the gas mix in the chamber as well as the mole count of each gas to the supermatter monitoring console
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Oct 22, 2024
@Migratingcocofruit Migratingcocofruit marked this pull request as draft October 22, 2024 19:06
@Migratingcocofruit
Copy link
Contributor Author

Drafting this until anomalies are figured out

@Henri215 Henri215 added Balance This PR will modify how effective something is or isnt Tweak This PR tweaks something ingame labels Oct 23, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Oct 28, 2024
@Migratingcocofruit
Copy link
Contributor Author

The issues here have been resolved for a while, but due to the PTL revert it puts me over the limit so I'm closing it for now.

@Migratingcocofruit
Copy link
Contributor Author

Singulo Buffs got merged so I'm back under the limit.

@Migratingcocofruit Migratingcocofruit marked this pull request as ready for review November 14, 2024 19:40
@Migratingcocofruit
Copy link
Contributor Author

200

@Migratingcocofruit
Copy link
Contributor Author

Migratingcocofruit commented Nov 25, 2024

PTL is merged for real now, so I am once again reopening this PR

@ParadiseSS13-Bot ParadiseSS13-Bot added the TGUI This PR modifies TGUI, will conflict label Nov 25, 2024
@Migratingcocofruit Migratingcocofruit changed the title SM crush bonus change Replaces The SM Crush Bonus With a New Mechanic: Gas Coefficient Nov 25, 2024
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Balance This PR will modify how effective something is or isnt Merge Conflict This PR is merge conflicted TGUI This PR modifies TGUI, will conflict Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants