Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: /New -> /Initialize §1: simple animals #27265

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

warriorstar-orion
Copy link
Contributor

@warriorstar-orion warriorstar-orion commented Nov 2, 2024

What Does This PR Do

This PR migrates all overrides of /New for simple animals to /Initialize.

Why It's Good For The Game

See #27261.

Testing

  • Ensured butterflies spawn in different colors.
  • Ensured chicks spawn with random pixel offsets.
  • Ensured mice spawn with different colors.
  • Ensured Runtime persistent data was registered at roundstart.
  • Ensured diona nymph names were randomized and rootspeak language added.
  • Ensured parrot player verbs were added and Poly had eng channel access. Perching continues to not work because it hasn't worked since [TM] Port TG Jump Point Search and SSpathfinder #18984 two years ago when the first JPS implementation was added because everything in the desired perches list is dense which means they count as an obstacle for pathfinding and I'm not fixing it because basic mobs will fix it, and also their flying trait doesn't get removed when perching so it looks like they're floating while sitting.
  • Ensured dragging admin ghost onto object properly creates possessed objects and spawning one manually properly stacktraces.
  • Ensured chickens were added to GLOB.chicken_count and their pixel offsets were randomized.

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AffectedArc07
Copy link
Member

PR seems fine, might be worth chucking it on TM for a day or so.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Testmerge Requested This PR has a pending testmerge request labels Nov 2, 2024
@warriorstar-orion
Copy link
Contributor Author

PR seems fine, might be worth chucking it on TM for a day or so.

Queued up for TM.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 5, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label Nov 16, 2024
Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TM has been on live for 4 days, 0 issues reported
SEND IT

@DGamerL DGamerL added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@SteelSlayer SteelSlayer added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@Burzah Burzah added this pull request to the merge queue Nov 21, 2024
Merged via the queue into ParadiseSS13:master with commit 9009e3a Nov 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Testmerge Active This PR is currently testmerged on production Testmerge Requested This PR has a pending testmerge request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants