Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluespace Harvester: Loot changes, Events, and more #27438

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

PollardTheDragon
Copy link
Contributor

What Does This PR Do

This PR enhances the Bluespace Harvester station goal by not only giving it a much-needed refresh in terms of reward types, but also in measures of quantity and risk.

Firstly, it revamps the entire BSH loot pool. The new loot pools are split between the following categories:

  • Clothing (Common, Uncommon, Rare)
  • Food (Common, Uncommon, Rare)
  • Cultural Artifacts (Common, Uncommon, Rare)
  • Biological Artifacts (Common, Uncommon, Rare)

The three rarity tiers each have a drop chance of 60, 30, and 10 respectively. The full loot table with odds can be found here: https://docs.google.com/spreadsheets/d/1zdA9LA2NTo3qpFtzkRRsIVcVtA_nxBvQj_SH2_En3-w/edit?usp=sharing

Whenever an item is purchased from the BSH, it will have a chance to spawn a second item somewhere on the station - at one of the NAD spawn points.

The BSH will automatically spawn an item at set intervals, based on the type of item spawned. This should ensure that most things get a chance to roll, instead of hats being the only thing bought by impatient crew.

When the BSH reaches the goal amount, it will spawn a large number of goods both around the BSH and around the station - this is the big reward for it succeeding, so that it may benefit more than just engineering.

The BSH, during operation, has a chance to encounter new events that are announced over the engineering radio. These events include radiation leaks, gas leaks, electrical surges, and dirt hazards. They are more common the higher the power.

Why It's Good For The Game

The BSH is a rather stale objective for the station currently. While Engineering gets to have some fun with min-maxing their generator, the payoff ultimately isn't worth it and doesn't really benefit the station. With these changes, some additional risk is present, in exchange for a much greater payoff that should affect more than just the engineering department.

Testing

Hooked up a BSH. Gave it power. Set points beyond intervals to trigger automatic spawns. Set points to interval to trigger goal spawn. Checked NAD spawn locations for item spawns. Started events, saw gas/radiation/dirt/arcs.

BSH.Example.mp4

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image


Changelog

🆑
add: Added bluespace harvester events
add: Bluespace harvester auto-spawning rewards at intervals
tweak: Adjusted the bluespace harvester reward pool heavily
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Nov 23, 2024
code/modules/station_goals/bluespace_tap_events.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap.dm Show resolved Hide resolved
code/modules/station_goals/bluespace_tap.dm Show resolved Hide resolved
code/modules/station_goals/bluespace_tap.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap.dm Show resolved Hide resolved
code/modules/station_goals/bluespace_tap.dm Outdated Show resolved Hide resolved
@PollardTheDragon PollardTheDragon marked this pull request as ready for review November 24, 2024 01:06
@ParadiseSS13-Bot ParadiseSS13-Bot added the Map Edit This PR will modify a map label Nov 24, 2024
Copy link
Contributor

@1080pCat 1080pCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor things + comments

code/game/objects/items/stacks/sheets/mineral.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap_lootpools.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap_lootpools.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap_lootpools.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap_lootpools.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap_lootpools.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap_lootpools.dm Outdated Show resolved Hide resolved
code/modules/station_goals/bluespace_tap_lootpools.dm Outdated Show resolved Hide resolved
PollardTheDragon and others added 4 commits November 24, 2024 01:34
Co-authored-by: 1080pCat <[email protected]>
Signed-off-by: PollardTheDragon <[email protected]>
Co-authored-by: 1080pCat <[email protected]>
Signed-off-by: PollardTheDragon <[email protected]>
Co-authored-by: 1080pCat <[email protected]>
Signed-off-by: PollardTheDragon <[email protected]>
@SynthTwo
Copy link
Contributor

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants