Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Crew monitor duplicating entries (second try) #27443

Merged
merged 3 commits into from
Dec 1, 2024
Merged

[FIX] Crew monitor duplicating entries (second try) #27443

merged 3 commits into from
Dec 1, 2024

Conversation

Drsmail
Copy link
Contributor

@Drsmail Drsmail commented Nov 24, 2024

What Does This PR Do

Fixes #14322

Why It's Good For The Game

Bags are bad, we kill thouse!

Testing

On local host, all works good

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: Fixed Crew monitor duplicating entries
/:cl:

@Drsmail Drsmail marked this pull request as ready for review November 24, 2024 04:39
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict labels Nov 24, 2024
@1080pCat 1080pCat added the Fix This PR will fix an issue in the game label Nov 24, 2024
Contrabang
Contrabang requested changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@Contrabang Contrabang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres a second .map in this file, can you apply this index strategy there too?

@Drsmail
Copy link
Contributor Author

Drsmail commented Nov 24, 2024

Theres a second .map in this file, can you apply this index strategy there too?

I don't know java that good. I got help with this code. So... i would prefere not to, but if some one will suggest a solution, i will test it.

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Nov 25, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 29, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Dec 1, 2024
@Burzah Burzah removed the Merge Conflict This PR is merge conflicted label Dec 1, 2024
@Burzah Burzah added this pull request to the merge queue Dec 1, 2024
Merged via the queue into ParadiseSS13:master with commit 529baf4 Dec 1, 2024
12 checks passed
@Drsmail Drsmail deleted the crew_monitor_fix branch December 1, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arthri Arthri Arthri requested changes

@Contrabang Contrabang Contrabang approved these changes

@Burzah Burzah Burzah approved these changes

Assignees
No one assigned
Labels
-Status: Awaiting merge This PR is ready for merge Fix This PR will fix an issue in the game TGUI This PR modifies TGUI, will conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crew Monitor duplicating crew entries
6 participants
@Drsmail @Arthri @Contrabang @Burzah @ParadiseSS13-Bot @1080pCat