More result details, minor enhancements #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbruch
reviewed
Dec 3, 2023
v3/vrs_p_r.py
Outdated
Comment on lines
71
to
74
| # ignore empty lines | ||
| if row[0].value is None: | ||
| continue | ||
|
|
There was a problem hiding this comment.
Could you describe what's happening here? Has the vrs_p_r file empty rows?
There was a problem hiding this comment.
I had the situation that LibreOffice just added empty rows at the end of the file, which ended up in lot's of errors, because empty lines don't validate.
hbruch
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds the ability to add more result details to v3 converters. It also fixes some minor issues like ignoring empty lines at Excel Import or the missing LXML package for XML imports.