Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: membership sale #328

Merged
merged 32 commits into from
Nov 30, 2023
Merged

feat: membership sale #328

merged 32 commits into from
Nov 30, 2023

Conversation

arr00
Copy link
Contributor

@arr00 arr00 commented Nov 14, 2023

No description provided.

Copy link

height bot commented Nov 14, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

github-actions bot commented Nov 14, 2023

Gas Report:
Create party custom metadata: 727886
Create party vanilla: 298514
Contribute to ETH party: 202694
Batch contribute two memberships to ETH party: 275336
Create proposal transfer eth: 136305
Execute proposal transfer eth: 123157
Create proposal distribute: 141158
Execute proposal distribute: 227506
Claim distribution: 72061

@0xble 0xble marked this pull request as ready for review November 14, 2023 16:43
@arr00
Copy link
Contributor Author

arr00 commented Nov 14, 2023

@0xble I believe that the fact that all delegates are only initial delegates should be documented.

@0xble 0xble changed the title feat: membership sale with history feat: membership sale Nov 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (b437f3d) 64.42% compared to head (2c321c7) 65.68%.

Files Patch % Lines
contracts/authorities/SellPartyCardsAuthority.sol 94.44% 4 Missing and 3 partials ⚠️
contracts/utils/LibSafeCast.sol 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   64.42%   65.68%   +1.26%     
==========================================
  Files          65       66       +1     
  Lines        2617     2751     +134     
  Branches      596      616      +20     
==========================================
+ Hits         1686     1807     +121     
- Misses        740      750      +10     
- Partials      191      194       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xble 0xble force-pushed the feat/membership-sale-origin branch from 417506f to 60787f2 Compare November 16, 2023 22:08
@arr00 arr00 merged commit de1b8f7 into main Nov 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants