Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigation: cache governance settings #332

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

arr00
Copy link
Contributor

@arr00 arr00 commented Nov 21, 2023

Mitigates C4 issue 413

Copy link

height bot commented Nov 21, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

github-actions bot commented Nov 22, 2023

Gas Report:
Accept Proposal: 32185
Create party custom metadata: 728024
Create party vanilla: 298657
Contribute to ETH party: 202783
Batch contribute two memberships to ETH party: 275559
Create proposal transfer eth: 141239
Execute proposal transfer eth: 123168
Create proposal distribute: 139593
Execute proposal distribute: 227447
Claim distribution: 72007

@arr00 arr00 force-pushed the mitigation/governance-params-413 branch from e249349 to 37443ba Compare November 22, 2023 15:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a978ca0) 65.24% compared to head (75d43b6) 65.37%.
Report is 3 commits behind head on c4-mitigations.

Additional details and impacted files
@@                Coverage Diff                 @@
##           c4-mitigations     #332      +/-   ##
==================================================
+ Coverage           65.24%   65.37%   +0.13%     
==================================================
  Files                  68       68              
  Lines                2759     2767       +8     
  Branches              618      622       +4     
==================================================
+ Hits                 1800     1809       +9     
+ Misses                763      762       -1     
  Partials              196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arr00 arr00 force-pushed the mitigation/governance-params-413 branch from 37443ba to fdac9d9 Compare November 29, 2023 18:54
@arr00 arr00 marked this pull request as ready for review November 29, 2023 18:54
@arr00 arr00 requested a review from 0xble November 29, 2023 18:55
@arr00 arr00 closed this Nov 29, 2023
@arr00 arr00 reopened this Nov 29, 2023
@arr00 arr00 requested review from 0xble and removed request for 0xble November 30, 2023 21:55
Copy link
Collaborator

@0xble 0xble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@arr00 arr00 merged commit 4b21a4e into c4-mitigations Nov 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants