Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(InitialETHCrowdfund): update delegate comments #335

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

0xble
Copy link
Collaborator

@0xble 0xble commented Nov 22, 2023

@0xble 0xble requested a review from arr00 November 22, 2023 19:09
Copy link

height bot commented Nov 22, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

Gas Report:
Accept Proposal: 32228
Create party custom metadata: 728006
Create party vanilla: 298639
Contribute to ETH party: 202800
Batch contribute two memberships to ETH party: 275593
Create proposal transfer eth: 140956
Execute proposal transfer eth: 123384
Create proposal distribute: 139310
Execute proposal distribute: 227670
Claim distribution: 72007

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2d01da) 65.56% compared to head (f5886b3) 65.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #335   +/-   ##
=======================================
  Coverage   65.56%   65.56%           
=======================================
  Files          68       68           
  Lines        2733     2733           
  Branches      619      619           
=======================================
  Hits         1792     1792           
  Misses        744      744           
  Partials      197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@arr00 arr00 merged commit b3f6b56 into c4-mitigations Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants