Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigation: 236-L07 avoid possible overflow #346

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

arr00
Copy link
Contributor

@arr00 arr00 commented Nov 27, 2023

C4 236 L07. Cast to avoid possible overflow in acceptanceRatio.

Copy link

height bot commented Nov 27, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@arr00 arr00 changed the title mitigation: 236-L06 avoid possible overflow mitigation: 236-L07 avoid possible overflow Nov 27, 2023
@arr00 arr00 requested a review from 0xble November 27, 2023 20:58
Copy link

Gas Report:
Accept Proposal: 32170
Create party custom metadata: 728006
Create party vanilla: 298639
Contribute to ETH party: 202800
Batch contribute two memberships to ETH party: 275593
Create proposal transfer eth: 140956
Execute proposal transfer eth: 123326
Create proposal distribute: 139310
Execute proposal distribute: 227612
Claim distribution: 72007

@arr00 arr00 merged commit e63e3f8 into c4-mitigations Nov 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant