Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ERC1155 to token gatekeeper #359

Closed
wants to merge 2 commits into from

Conversation

arr00
Copy link
Contributor

@arr00 arr00 commented Dec 5, 2023

Link T-3764

Copy link

height bot commented Dec 5, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-3764" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

Copy link

github-actions bot commented Dec 5, 2023

Gas Report:
Create party custom metadata: 727886
Create party vanilla: 298514
Contribute to ETH party: 202694
Batch contribute two memberships to ETH party: 275336
Create proposal transfer eth: 136305
Execute proposal transfer eth: 123157
Create proposal distribute: 141158
Execute proposal distribute: 227506
Claim distribution: 72061

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e63924f) 65.70% compared to head (09c798c) 65.64%.

❗ Current head 09c798c differs from pull request most recent head e3cc70b. Consider uploading reports for the commit e3cc70b to get more accurate results

Files Patch % Lines
contracts/gatekeepers/TokenGateKeeper.sol 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   65.70%   65.64%   -0.06%     
==========================================
  Files          66       66              
  Lines        2761     2765       +4     
  Branches      619      620       +1     
==========================================
+ Hits         1814     1815       +1     
- Misses        754      756       +2     
- Partials      193      194       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arr00 arr00 requested a review from 0xble December 5, 2023 19:20
@arr00 arr00 marked this pull request as ready for review December 5, 2023 19:20
@arr00
Copy link
Contributor Author

arr00 commented Mar 25, 2024

Seems like this won't happen

@arr00 arr00 closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants