Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cardinality of opentelemetry span names on client-side navigation #1

Closed
wants to merge 15 commits into from

Conversation

PatNeedham
Copy link
Owner

Duplicate of vercel#59282 in order to (hopefully) regenerate the GH Action logs from the failing tests.

For Contributors

Fixing a bug

  • Fixes High-cardinality HTTP span names vercel/next.js#54694 (at least partially)
  • Adds test case for client-side navigation previously leading to wrong span attributes (test added into the test/e2e/opentelemetry test suite)
  • Updated test/e2e/opentelemetry app used to test telemetry (some pages with link between them where created but not quite correct in the links, and were not handling the defined params)

Adding a feature

What?

As noticed in issue vercel#54694, span names for dynamic routes are not consistent and sometimes miss the "next.route" attribute, and have a span name that have the parameters instead of the capturing placeholders.

@PatNeedham PatNeedham closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High-cardinality HTTP span names
2 participants