[i] Fix ResourcePackCreator#isEmpty not working correctly

Patbox · Jan 29, 2023 · 4cbce89 · 4cbce89
1 parent 5c04635
commit 4cbce89
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -12,7 +12,7 @@ fabric_version=0.51.1+1.18.2
 
 maven_group = eu.pb4
 
-all_version = 0.2.0-rc.4.7
-core_version = 0.2.0-rc.4.7
+all_version = 0.2.0-rc.4.8
+core_version = 0.2.0-rc.4.8
 blocks_ext_version = 0.1.0-alpha.7
 mod_patches_version = 0.0.0-alpha.0
diff --git a/polymer/src/main/java/eu/pb4/polymer/api/resourcepack/ResourcePackCreator.java b/polymer/src/main/java/eu/pb4/polymer/api/resourcepack/ResourcePackCreator.java
@@ -140,15 +140,14 @@ public byte[] getPackIcon() {
     }
 
     public boolean isEmpty() {
-        return this.items.values().size() <= 0 || this.modIds.size() <= 0 || this.armorModelMap.size() <= 0;
+        return this.items.isEmpty() && this.modIds.isEmpty() && this.armorModelMap.isEmpty() && this.creationEvent.isEmpty();
     }
 
     public boolean build(Path output) throws ExecutionException, InterruptedException {
         boolean successful = true;
 
         var builder = new DefaultRPBuilder(output);
 
-
         if (this.packDescription != null) {
             builder.addData("pack.mcmeta", ("" +
                     "{\n" +

diff --git a/polymer/src/main/java/eu/pb4/polymer/api/utils/events/SimpleEvent.java b/polymer/src/main/java/eu/pb4/polymer/api/utils/events/SimpleEvent.java
@@ -26,4 +26,8 @@ public void invoke(Consumer<T> invoker) {
             invoker.accept(handler);
         }
     }
+
+    public boolean isEmpty() {
+        return this.handlers.isEmpty();
+    }
 }