Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom docs UI fixes #126

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Custom docs UI fixes #126

wants to merge 14 commits into from

Conversation

maxpumperla
Copy link
Contributor

No description provided.

@slinlee slinlee linked an issue Aug 13, 2021 that may be closed by this pull request
Add a link back to the experiment from the policy server docs #87
Open
@slinlee
Copy link
Contributor

slinlee commented Aug 31, 2021

@maxpumperla for the auto tests I'm running into an issue where if I run pytest tests/ the schema.yaml and saved model aren't copied first. Pytest imports all the modules and when it gets to config.py that one expects the schema.yaml to exist already.

You can see the error output here https://github.com/SkymindIO/policy-server/pull/126/checks

Do you have a go-to way to avoid this? Do you kick off tests differently? Thanks.

@maxpumperla
Copy link
Contributor Author

@slinlee no, I've been trying to resolve this last week. Actually I have tests for all examples ready locally that are parametrised unit tests, but only the first will pass. I'm not quite sure how to address this yet.

@slinlee
Copy link
Contributor

slinlee commented Aug 31, 2021

@slinlee no, I've been trying to resolve this last week. Actually I have tests for all examples ready locally that are parametrised unit tests, but only the first will pass. I'm not quite sure how to address this yet.

@maxpumperla will only the first one pass even when you're running it locally?

@maxpumperla
Copy link
Contributor Author

yes, I don't know the reason for it. it might be the way pytest collects tests. But even then, if I sleep for long enough, I should be able to make the tests pass, but it doesn't quite seem to work. Also, as suspected, sometimes we do need the timestep key word and sometimes we don't. I suspect it's the tensorflow version used, but I don't find anything in their docs (or those of ray).

@slinlee
Load mouse and cheese schema to get tests to pass
7d1ffe2 
This isn't a real fix. It just happens to work since test_app.py is the
only one that actually tests against the schema.

pytest seems to load config.py once, which sets the global params like
schema with whatever files are there first.
@slinlee
Copy link
Contributor

slinlee commented Aug 31, 2021

yes, I don't know the reason for it. it might be the way pytest collects tests. But even then, if I sleep for long enough, I should be able to make the tests pass, but it doesn't quite seem to work. Also, as suspected, sometimes we do need the timestep key word and sometimes we don't. I suspect it's the tensorflow version used, but I don't find anything in their docs (or those of ray).

@maxpumperla
I was hoping that pytest --forked would help us at least have config.py set up properly for each suite of tests. It seems to crash for me though. https://github.com/pytest-dev/pytest-forked

@maxpumperla
Copy link
Contributor Author

@slinlee thanks, let me have a closer look at this tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a link back to the experiment from the policy server docs
2 participants
@maxpumperla @slinlee