Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping #45

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Housekeeping #45

merged 4 commits into from
Aug 27, 2024

Conversation

petschki
Copy link
Member

  • update dependencies
  • remove Stamen Toner -> has moved to payed Stadia Maps service

@petschki petschki requested a review from thet August 26, 2024 08:22
Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I‌ added a commit which uses the already parsed options from the BasePattern initialization.

I'm chewing on the removal of Stamen.toner regarding backwards compatibility.
But:

  1. If people have a customized map_layers config, then there is no change for them.

2)‌ If someone has the stamen toner layer configured in default_map_layer then it will still be used.

Except that Stamen.toner is now Stadia.toner.

I think it's better if it doesn't work than accidentally breaking the license rules.

Approved :D +1 🎇

@thet thet merged commit d568dbc into master Aug 27, 2024
1 check passed
@thet thet deleted the housekeeping branch August 27, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants