-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Nextcloud 29 #114
base: master
Are you sure you want to change the base?
Conversation
858d0ff
to
45d83dc
Compare
@PaulLereverend requesting review. |
looks like he is gone, maybe you can publish a fork? :) |
Hi, The extract part is working OK. I only get this message in the Logging {"reqId":"F20lQv5g9K338PfmPUlB","level":3,"time":"2024-11-04T10:47:30+00:00","remoteAddr":"172.17.0.1","user":"admin","app":"jsresourceloader","method":"GET","url":"/apps/files/","message":"Could not find resource extract/js/extraction.js to load","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36","version":"29.0.7.1","data":{"app":"jsresourceloader"},"id":"6728a657f28ef"} |
@redblom Hi Thanks for the update, Do you have time to take a look at the issue I posted above? |
I do not experience this (cannot reproduce). Also this version of the extract app has no reference to |
@redblom,
I have downloaded your release and installed that version.
When I look in the repo in the file LoadExtractActions.php I find this entry, line 28.
Isn’t that the line that tries to load the “extract/js/extraction.js” file?
class LoadExtractActions implements IEventListener
{
public function handle(Event $event): void
{
if (!($event instanceof LoadAdditionalScriptsEvent)) {
return;
}
Util::addInitScript(Application::APP_ID, 'extract-init');
Util::addScript(Application::APP_ID, 'extract-extractAction');
Util::addScript(Application::APP_ID, 'extraction');
Util::addStyle(Application::APP_ID, 'style');
}
}
|
@JurgenWauters oops :) I was working on an already updated in house branch. |
@redblom Big thanks for the update, is it also possible to make a new release? |
Yeah, where's the new release so people can actually benefit from this? |
Can someone please explain how to install this version of the app in Nextcloud 30 AIO docker? |
Switch to vue frontend.
Fixes NC 29 compatibility issues.
Fixes #113, #110, #108