Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USB] Change endpoint0_setup argument type from uint64_t to setup_t #757

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

forderud
Copy link

This eliminates the need for converting between the types through the bothwords union member, which makes it a bit easier to follow the endpoint0_setup implementation. It also saves 64bit stack space, since the setup_t setup variable can be eliminated.

@forderud forderud changed the title Change endpoint0_setup argument type from uint64_t to setup_t [USB] Change endpoint0_setup argument type from uint64_t to setup_t Sep 21, 2024
This eliminates the need for converting between the types through the "bothwords" union member, which makes it a bit easier to follow the endpoint0_setup implementation. It also saves 64bit stack space, since the "setup_t setup" variable can be eliminated.
… use.

The setup_t struct is a union, so the field removal won't affect the struct size.
@forderud forderud force-pushed the endpoint0_setup-arg branch from a6b3793 to 6775c61 Compare October 2, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant