Fix File to mark overridden functions as 'override' #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssilverman
force-pushed
the
fix-fs-mark-functions-override
branch
2 times, most recently
from
6040e45
to
a7bff4f
Compare
Enables a File object to be used via a pointer or reference to Stream and Print, and use the proper overridden functions. Without 'virtual' or 'override', the default Stream and Print functions will be used instead.
ssilverman
force-pushed
the
fix-fs-mark-functions-override
branch
from
a7bff4f
to
801cec2
Compare
|
Note to reviewer: I can use 'virtual' instead, if you like, but the following PR will change all overridden methods to use 'override' instead of 'virtual': #771. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables a File object to be used via a pointer or reference to Stream
and Print, and use the proper overridden functions. Without 'virtual'
or 'override', the default Stream and Print functions will be
used instead.