Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message #92

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Better error message #92

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
98574ce
Fix #71
Pebaz Jul 26, 2023
a84d908
Fix broken type hints for nested functions
Pebaz Jul 27, 2023
0b8c280
Race conditions on Windows during tests
Pebaz Jul 27, 2023
e463667
Fix type hints
Pebaz Jul 27, 2023
9a62dd3
Fix type hints
Pebaz Jul 27, 2023
d469720
Adding all_workflows.yml
Pebaz Jul 28, 2023
ba07d0c
Removing unneeded workflows
Pebaz Jul 28, 2023
757661b
Remove YAML anchor
Pebaz Jul 28, 2023
1ccdf03
Fixed type checking
Pebaz Jul 28, 2023
4b917b7
Fixing typing errors accross Python versions
Pebaz Jul 28, 2023
2b6fc6f
Improve telemetry
Pebaz Jul 28, 2023
23b4625
Testing out new way of uninstalling nimporter
Pebaz Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve telemetry
  • Loading branch information
@Pebaz
Pebaz committed Jul 28, 2023
commit 2b6fc6fc3b0f3de076ceef93ae0bf82252415d77
2 changes: 1 addition & 1 deletion nimporter/nexporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,6 @@ def _is_semver(string: str) -> bool:
mod_name = '@'.join(segments[index:])
break

new_name = ic(f'NIMPORTER@{mod_name}')
new_name = f'NIMPORTER@{mod_name}'
item.replace(item.with_name(new_name))
return
6 changes: 4 additions & 2 deletions tests/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@ def temporarily_install_nimporter():
time.sleep(5)

try:
code, _, _ = run_process(
code, out, err = run_process(
shlex.split(f'{PYTHON} setup.py install --force'),
'NIMPORTER_INSTRUMENT' in os.environ
)

assert code == 0, 'Nimporter failed to install'
assert code == 0, (
f'Nimporter failed to install:\nstdout: {out}\nstderr: {err}'
)

yield
finally:
Expand Down