add nil check since there's a codepath where normalize activity retur…

…ns nil
PeerDB-io · Jan 2, 2024 · 0ebe58a · 0ebe58a
1 parent ac64802
commit 0ebe58a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/flow/activities/flowable.go b/flow/activities/flowable.go
@@ -432,10 +432,8 @@ func (a *FlowableActivity) StartNormalize(
 	}
 
 	// log the number of batches normalized
-	if res != nil {
-		slog.InfoContext(ctx, fmt.Sprintf("normalized records from batch %d to batch %d\n",
-			res.StartBatchID, res.EndBatchID))
-	}
+	slog.InfoContext(ctx, fmt.Sprintf("normalized records from batch %d to batch %d\n",
+		res.StartBatchID, res.EndBatchID))
 
 	return res, nil
 }

diff --git a/flow/workflows/normalize_flow.go b/flow/workflows/normalize_flow.go
@@ -35,7 +35,7 @@ func NormalizeFlowWorkflow(ctx workflow.Context,
 			var normalizeResponse *model.NormalizeResponse
 			if err := fStartNormalize.Get(normalizeFlowCtx, &normalizeResponse); err != nil {
 				errors = append(errors, err.Error())
-			} else {
+			} else if normalizeResponse != nil {
 				results = append(results, *normalizeResponse)
 			}
 		}