Skip to content

Commit

Permalink
Eventhub: fix logs and metadatadb requirement (#1055)
Browse files Browse the repository at this point in the history
Removes metadatadb requirement for Eventhub Group peer as it can use
catalog on its own
Fixes a few logs
  • Loading branch information
Amogh-Bharadwaj authored Jan 11, 2024
1 parent e045b4c commit 19da0fb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
4 changes: 2 additions & 2 deletions flow/connectors/eventhub/eventhub.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func (c *EventHubConnector) Close() error {

err = c.hubManager.Close(context.Background())
if err != nil {
slog.Error("failed to close event hub manager", slog.Any("error", err))
c.logger.Error("failed to close event hub manager", slog.Any("error", err))
allErrors = errors.Join(allErrors, err)
}

Expand Down Expand Up @@ -240,7 +240,7 @@ func (c *EventHubConnector) SyncRecords(req *model.SyncRecordsRequest) (*model.S

lastCheckpoint, err := req.Records.GetLastCheckpoint()
if err != nil {
c.logger.Error("failed to get last checkpoint", err)
c.logger.Error("failed to get last checkpoint", slog.Any("error", err))
return nil, err
}

Expand Down
5 changes: 0 additions & 5 deletions nexus/analyzer/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -749,11 +749,6 @@ fn parse_db_options(
let conn_str = opts.get("metadata_db");
let metadata_db = parse_metadata_db_info(conn_str.copied())?;

// metadata_db is required for eventhub group
if metadata_db.is_none() {
anyhow::bail!("metadata_db is required for eventhub group");
}

// split comma separated list of columns and trim
let unnest_columns = opts
.get("unnest_columns")
Expand Down

0 comments on commit 19da0fb

Please sign in to comment.