Skip to content

Commit

Permalink
remove no longer used parameter
Browse files Browse the repository at this point in the history
  • Loading branch information
serprex committed Jan 5, 2024
1 parent c1ddff7 commit 1b989fa
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions flow/e2e/snowflake/qrep_flow_sf_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,10 @@ func (s PeerFlowE2ETestSuiteSF) checkJSONValue(tableName, colName, fieldName, va
return nil
}

func (s PeerFlowE2ETestSuiteSF) compareTableContentsWithDiffSelectorsSF(tableName, pgSelector, sfSelector string,
tableCaseSensitive bool,
) {
func (s PeerFlowE2ETestSuiteSF) compareTableContentsWithDiffSelectorsSF(tableName, pgSelector, sfSelector string) {
pgRows, err := e2e.GetPgRows(s.pool, s.pgSuffix, tableName, pgSelector)
require.NoError(s.t, err)

if tableCaseSensitive {
tableName = fmt.Sprintf("\"%s\"", tableName)
}
sfRows, err := s.GetRows(tableName, sfSelector)
require.NoError(s.t, err)

Expand Down Expand Up @@ -83,7 +78,7 @@ func (s PeerFlowE2ETestSuiteSF) Test_Complete_QRep_Flow_Avro_SF() {
require.NoError(s.t, err)

sel := e2e.GetOwnersSelectorStringsSF()
s.compareTableContentsWithDiffSelectorsSF(tblName, sel[0], sel[1], false)
s.compareTableContentsWithDiffSelectorsSF(tblName, sel[0], sel[1])

err = s.checkJSONValue(dstSchemaQualified, "f7", "key", "\"value\"")
require.NoError(s.t, err)
Expand Down Expand Up @@ -129,7 +124,7 @@ func (s PeerFlowE2ETestSuiteSF) Test_Complete_QRep_Flow_Avro_SF_Upsert_Simple()
require.NoError(s.t, err)

sel := e2e.GetOwnersSelectorStringsSF()
s.compareTableContentsWithDiffSelectorsSF(tblName, sel[0], sel[1], false)
s.compareTableContentsWithDiffSelectorsSF(tblName, sel[0], sel[1])
}

func (s PeerFlowE2ETestSuiteSF) Test_Complete_QRep_Flow_Avro_SF_S3() {
Expand Down Expand Up @@ -169,7 +164,7 @@ func (s PeerFlowE2ETestSuiteSF) Test_Complete_QRep_Flow_Avro_SF_S3() {
require.NoError(s.t, err)

sel := e2e.GetOwnersSelectorStringsSF()
s.compareTableContentsWithDiffSelectorsSF(tblName, sel[0], sel[1], false)
s.compareTableContentsWithDiffSelectorsSF(tblName, sel[0], sel[1])
}

func (s PeerFlowE2ETestSuiteSF) Test_Complete_QRep_Flow_Avro_SF_Upsert_XMIN() {
Expand Down Expand Up @@ -213,7 +208,7 @@ func (s PeerFlowE2ETestSuiteSF) Test_Complete_QRep_Flow_Avro_SF_Upsert_XMIN() {
require.NoError(s.t, err)

sel := e2e.GetOwnersSelectorStringsSF()
s.compareTableContentsWithDiffSelectorsSF(tblName, sel[0], sel[1], false)
s.compareTableContentsWithDiffSelectorsSF(tblName, sel[0], sel[1])
}

func (s PeerFlowE2ETestSuiteSF) Test_Complete_QRep_Flow_Avro_SF_S3_Integration() {
Expand Down Expand Up @@ -256,7 +251,7 @@ func (s PeerFlowE2ETestSuiteSF) Test_Complete_QRep_Flow_Avro_SF_S3_Integration()
require.NoError(s.t, err)

sel := e2e.GetOwnersSelectorStringsSF()
s.compareTableContentsWithDiffSelectorsSF(tblName, sel[0], sel[1], false)
s.compareTableContentsWithDiffSelectorsSF(tblName, sel[0], sel[1])
}

func (s PeerFlowE2ETestSuiteSF) Test_PeerDB_Columns_QRep_SF() {
Expand Down

0 comments on commit 1b989fa

Please sign in to comment.