Clickhouse: remove gettableschema step in cdc (#1760)

This function call is not actually used downstream and is an unnecessary call to clickhouse
PeerDB-io · May 27, 2024 · 2ac6aff · 2ac6aff
1 parent df919c2
commit 2ac6aff
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/flow/connectors/clickhouse/cdc.go b/flow/connectors/clickhouse/cdc.go
@@ -85,12 +85,7 @@ func (c *ClickhouseConnector) syncRecordsViaAvro(
 		DestinationTableIdentifier: strings.ToLower(rawTableIdentifier),
 	}
 	avroSyncer := NewClickhouseAvroSyncMethod(qrepConfig, c)
-	destinationTableSchema, err := c.getTableSchema(qrepConfig.DestinationTableIdentifier)
-	if err != nil {
-		return nil, err
-	}
-
-	numRecords, err := avroSyncer.SyncRecords(ctx, destinationTableSchema, stream, req.FlowJobName)
+	numRecords, err := avroSyncer.SyncRecords(ctx, stream, req.FlowJobName)
 	if err != nil {
 		return nil, err
 	}

diff --git a/flow/connectors/clickhouse/qrep_avro_sync.go b/flow/connectors/clickhouse/qrep_avro_sync.go
@@ -62,7 +62,6 @@ func (s *ClickhouseAvroSyncMethod) CopyStageToDestination(ctx context.Context, a
 
 func (s *ClickhouseAvroSyncMethod) SyncRecords(
 	ctx context.Context,
-	dstTableSchema []*sql.ColumnType,
 	stream *model.QRecordStream,
 	flowJobName string,
 ) (int, error) {