fixed lint and tests

PeerDB-io · Feb 29, 2024 · 2d4d3bd · 2d4d3bd
1 parent 983fa5f
commit 2d4d3bd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/flow/connectors/core.go b/flow/connectors/core.go
@@ -264,6 +264,7 @@ var (
 	_ QRepSyncConnector = &connbigquery.BigQueryConnector{}
 	_ QRepSyncConnector = &connsnowflake.SnowflakeConnector{}
 	_ QRepSyncConnector = &connclickhouse.ClickhouseConnector{}
+	_ QRepSyncConnector = &conns3.S3Connector{}
 
 	_ QRepConsolidateConnector = &connsnowflake.SnowflakeConnector{}
 	_ QRepConsolidateConnector = &connclickhouse.ClickhouseConnector{}

diff --git a/flow/connectors/postgres/qrep.go b/flow/connectors/postgres/qrep.go
@@ -578,7 +578,8 @@ func BuildQuery(logger log.Logger, query string, flowJobName string) (string, er
 
 // IsQRepPartitionSynced checks whether a specific partition is synced
 func (c *PostgresConnector) IsQRepPartitionSynced(ctx context.Context,
-	req *protos.IsQRepPartitionSyncedInput) (bool, error) {
+	req *protos.IsQRepPartitionSyncedInput,
+) (bool, error) {
 	// setup the query string
 	metadataTableIdentifier := pgx.Identifier{c.metadataSchema, qRepMetadataTableName}
 	queryString := fmt.Sprintf(

diff --git a/flow/connectors/s3/qrep.go b/flow/connectors/s3/qrep.go
@@ -81,3 +81,10 @@ func (c *S3Connector) SetupQRepMetadataTables(_ context.Context, config *protos.
 	c.logger.Info("QRep metadata setup not needed for S3.")
 	return nil
 }
+
+// S3 doesn't appear to check if the partition already exists
+func (c *S3Connector) IsQRepPartitionSynced(_ context.Context,
+	config *protos.IsQRepPartitionSyncedInput,
+) (bool, error) {
+	return false, nil
+}